Add UMA for the app list doodle being clicked.

Add UMA for the app list doodle being clicked.

This CL adds the Apps.AppListDoodleClicked histogram for when the app
list doodle is clicked.

BUG=459650
Committed: https://crrev.com/12182aef98bb7b909dd53b43aa3a76b37d367637
Cr-Commit-Position: refs/heads/master@{#317286}

[calamity, 2015-02-19 06:44:19]

calamity@chromium.org changed reviewers:
+ asvitkine@chromium.org, mgiuca@chromium.org

[calamity, 2015-02-19 06:44:19]

+mgiuca for general review.
+asvitkine for histograms OWNERS.

[Matt Giuca, 2015-02-19 08:37:37]

lgtm

asvitkine: As with the other CL, this is a launch blocker.

[Alexei Svitkine (slow), 2015-02-19 14:56:23]

https://codereview.chromium.org/930243009/diff/1/chrome/browser/ui/webui/app_...
File chrome/browser/ui/webui/app_list/start_page_handler.cc (right):

https://codereview.chromium.org/930243009/diff/1/chrome/browser/ui/webui/app_...
chrome/browser/ui/webui/app_list/start_page_handler.cc:121:
UMA_HISTOGRAM_ENUMERATION("Apps.AppListDoodleClicked", 1, 2);
Please use UMA_HISTOGRAM_BOOLEAN(), which produces the same result.

https://codereview.chromium.org/930243009/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/930243009/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:471: +    The number of times the app
list doodle is clicked. This is logged each
What will the absolute number tell you? e.g. what does 384731 mean?

Usually, it's better to have metrics that have a corresponding baseline - so you
can say what percentage of the overall resulted in this action. For example, in
this case, a good baseline might be how many times the applist doodle was shown.

[Matt Giuca, 2015-02-19 21:54:00]

https://codereview.chromium.org/930243009/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/930243009/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:471: +    The number of times the app
list doodle is clicked. This is logged each
On 2015/02/19 14:56:23, Alexei Svitkine wrote:
> What will the absolute number tell you? e.g. what does 384731 mean?
> 
> Usually, it's better to have metrics that have a corresponding baseline - so
you
> can say what percentage of the overall resulted in this action. For example,
in
> this case, a good baseline might be how many times the applist doodle was
shown.

We will compare it to the other stats such as how often the launcher is opened.

For example, AppListDoodleClicked / (number of app list launches).

Having said that, I can't find a stat which tells you how many times the app
list is launched. Is there a way to read that out of a stat like
AppListWarmupDuration? I'd prefer if there was just a stat that collects app
list launches.

[Alexei Svitkine (slow), 2015-02-19 22:08:20]

LGTM per Matt's request, so as not to block you, assuming you address my
comments. Thanks!

https://codereview.chromium.org/930243009/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/930243009/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:471: +    The number of times the app
list doodle is clicked. This is logged each
On 2015/02/19 21:54:00, Matt Giuca wrote:
> On 2015/02/19 14:56:23, Alexei Svitkine wrote:
> > What will the absolute number tell you? e.g. what does 384731 mean?
> > 
> > Usually, it's better to have metrics that have a corresponding baseline - so
> you
> > can say what percentage of the overall resulted in this action. For example,
> in
> > this case, a good baseline might be how many times the applist doodle was
> shown.
> 
> We will compare it to the other stats such as how often the launcher is
opened.
> 
> For example, AppListDoodleClicked / (number of app list launches).
> 
> Having said that, I can't find a stat which tells you how many times the app
> list is launched. Is there a way to read that out of a stat like
> AppListWarmupDuration? I'd prefer if there was just a stat that collects app
> list launches.

When you find the stat, please update this histograms' description to mention
this.

Otherwise, I'm OK if you just add app launches to this histogram, so that it's
an enum histogram with the following buckets:

APP_LAUNCHED = 0,
DOODLE_CLICKED = 1

Then, it's much easier to see everything in one histogram than having to open
multiple histograms and try to correlate things. And you'd automatically get
things like timeline dashboard to plot percentages of an enum over time.

[calamity, 2015-02-20 03:14:11]

New patchsets have been uploaded after l-g-t-m from
mgiuca@chromium.org,asvitkine@chromium.org

[calamity, 2015-02-20 03:19:32]

Implemented the 2-value enum with when the doodle is shown and when the doodle
is clicked. This will let us track the click-through rate of the doodle.

https://codereview.chromium.org/930243009/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/930243009/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:471: +    The number of times the app
list doodle is clicked. This is logged each
On 2015/02/19 22:08:20, Alexei Svitkine wrote:
> On 2015/02/19 21:54:00, Matt Giuca wrote:
> > On 2015/02/19 14:56:23, Alexei Svitkine wrote:
> > > What will the absolute number tell you? e.g. what does 384731 mean?
> > > 
> > > Usually, it's better to have metrics that have a corresponding baseline -
so
> > you
> > > can say what percentage of the overall resulted in this action. For
example,
> > in
> > > this case, a good baseline might be how many times the applist doodle was
> > shown.
> > 
> > We will compare it to the other stats such as how often the launcher is
> opened.
> > 
> > For example, AppListDoodleClicked / (number of app list launches).
> > 
> > Having said that, I can't find a stat which tells you how many times the app
> > list is launched. Is there a way to read that out of a stat like
> > AppListWarmupDuration? I'd prefer if there was just a stat that collects app
> > list launches.
> 
> When you find the stat, please update this histograms' description to mention
> this.
> 
> Otherwise, I'm OK if you just add app launches to this histogram, so that it's
> an enum histogram with the following buckets:
> 
> APP_LAUNCHED = 0,
> DOODLE_CLICKED = 1
> 
> Then, it's much easier to see everything in one histogram than having to open
> multiple histograms and try to correlate things. And you'd automatically get
> things like timeline dashboard to plot percentages of an enum over time.

Done.

[Matt Giuca, 2015-02-20 04:37:43]

still lgtm

[calamity, 2015-02-20 04:45:28]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2015-02-20 04:46:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/930243009/40001

[commit-bot: I haz the power, 2015-02-20 06:01:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-20 06:01:39]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[calamity, 2015-02-20 06:51:32]

New patchsets have been uploaded after l-g-t-m from mgiuca@chromium.org

[calamity, 2015-02-20 06:53:55]

The CQ bit was checked by calamity@chromium.org

[Matt Giuca, 2015-02-20 06:53:56]

slgtm

[calamity, 2015-02-20 07:35:50]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2015-02-20 07:36:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/930243009/60001

[commit-bot: I haz the power, 2015-02-20 11:10:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-20 11:11:25]

Patchset 4 (id:??) landed as
https://crrev.com/12182aef98bb7b909dd53b43aa3a76b37d367637
Cr-Commit-Position: refs/heads/master@{#317286}