Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4254)

Unified Diff: chrome/browser/resources/app_list/start_page.js

Issue 930243009: Add UMA for the app list doodle being clicked. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@uma
Patch Set: fix tests Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/app_list/start_page_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/app_list/start_page.js
diff --git a/chrome/browser/resources/app_list/start_page.js b/chrome/browser/resources/app_list/start_page.js
index e2055924bb0fb9754be036696958816b3e400720..fc5ebc4cd7b3bdc8cfbeb68c1c363c69a028ef63 100644
--- a/chrome/browser/resources/app_list/start_page.js
+++ b/chrome/browser/resources/app_list/start_page.js
@@ -46,8 +46,11 @@ cr.define('appList.startPage', function() {
*
* @param {boolean} hotwordEnabled Whether the hotword is enabled or not.
*/
- function onAppListShown(hotwordEnabled) {
- speechManager.onShown(hotwordEnabled);
+ function onAppListShown(hotwordEnabled, legacySpeechEnabled) {
+ if (legacySpeechEnabled)
+ speechManager.onShown(hotwordEnabled);
+
+ chrome.send('appListShown', [this.doodle != null]);
}
/**
@@ -112,6 +115,10 @@ cr.define('appList.startPage', function() {
doodleLink.href = doodleData.target_url;
doodleLink.target = '_blank';
doodleLink.appendChild(doodleImage);
+ doodleLink.onclick = function() {
+ chrome.send('doodleClicked');
+ return true;
+ };
this.doodle.appendChild(doodleLink);
} else {
this.doodle.appendChild(doodleImage);
« no previous file with comments | « no previous file | chrome/browser/ui/app_list/start_page_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698