Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/browser/ui/app_list/start_page_service.cc

Issue 930243009: Add UMA for the app list doodle being clicked. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@uma
Patch Set: fix tests Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/start_page_service.cc
diff --git a/chrome/browser/ui/app_list/start_page_service.cc b/chrome/browser/ui/app_list/start_page_service.cc
index d389dc2be042439244ea943d757500720c3deb4e..f02376be9db705621e5e1548b9e0ef5d198cd66c 100644
--- a/chrome/browser/ui/app_list/start_page_service.cc
+++ b/chrome/browser/ui/app_list/start_page_service.cc
@@ -352,14 +352,15 @@ void StartPageService::AppListShown() {
LoadContents();
} else if (contents_->IsCrashed()) {
LoadStartPageURL();
- } else if (contents_->GetWebUI() &&
- !HotwordService::IsExperimentalHotwordingEnabled()) {
- // If experimental hotwording is enabled, don't call onAppListShown.
- // onAppListShown() initializes the web speech API, which is not used with
+ } else if (contents_->GetWebUI()) {
+ // If experimental hotwording is enabled, don't initialize the web speech
+ // API, which is not used with
// experimental hotwording.
contents_->GetWebUI()->CallJavascriptFunction(
"appList.startPage.onAppListShown",
- base::FundamentalValue(HotwordEnabled()));
+ base::FundamentalValue(HotwordEnabled()),
+ base::FundamentalValue(
+ !HotwordService::IsExperimentalHotwordingEnabled()));
}
#if defined(OS_CHROMEOS)
« no previous file with comments | « chrome/browser/resources/app_list/start_page.js ('k') | chrome/browser/ui/webui/app_list/start_page_browsertest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698