Source/bindings/core/v8/ScriptStreamer.cpp - Issue 929953002: CachedMetadata support for ServiceWorker script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptStreamer.cpp

Issue 929953002: CachedMetadata support for ServiceWorker script. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: incorporated tkent's comment Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/ScriptStreamer.cpp

diff --git a/Source/bindings/core/v8/ScriptStreamer.cpp b/Source/bindings/core/v8/ScriptStreamer.cpp

index be5b7d2d2e508614395fd8020d769336f4e5489e..d93dc8d2265776035432f1815f03e131142437c5 100644

--- a/Source/bindings/core/v8/ScriptStreamer.cpp

+++ b/Source/bindings/core/v8/ScriptStreamer.cpp

@@ -160,7 +160,8 @@ private:

// BOM can only occur at the beginning of the data.

ASSERT(lengthOfBOM == 0 || m_dataPosition == 0);

- if (streamer->resource()->cachedMetadata(V8ScriptRunner::tagForCodeCache(streamer->resource()))) {

+ CachedMetadataHandler* cacheHandler = streamer->resource()->cacheHandler();

+ if (cacheHandler && cacheHandler->cachedMetadata(V8ScriptRunner::tagForCodeCache(cacheHandler))) {

// The resource has a code cache, so it's unnecessary to stream and

// parse the code. Cancel the streaming and resume the non-streaming

// code path.