Source/bindings/core/v8/ScriptDebugServer.cpp - Issue 929953002: CachedMetadata support for ServiceWorker script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptDebugServer.cpp

Issue 929953002: CachedMetadata support for ServiceWorker script. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: incorporated tkent's comment Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/ScriptDebugServer.cpp

diff --git a/Source/bindings/core/v8/ScriptDebugServer.cpp b/Source/bindings/core/v8/ScriptDebugServer.cpp

index a514532d96dc7c31546f9ce7dc31c539e81e58c4..9b224f7b4fb2f79a9ffbc24e64a7651f6b995d8b 100644

--- a/Source/bindings/core/v8/ScriptDebugServer.cpp

+++ b/Source/bindings/core/v8/ScriptDebugServer.cpp

@@ -691,7 +691,7 @@ void ScriptDebugServer::compileScript(ScriptState* scriptState, const String& ex

v8::Handle<v8::String> source = v8String(m_isolate, expression);

v8::TryCatch tryCatch;

- v8::Local<v8::Script> script = V8ScriptRunner::compileScript(source, sourceURL, TextPosition(), 0, 0, m_isolate);

+ v8::Local<v8::Script> script = V8ScriptRunner::compileScript(source, sourceURL, TextPosition(), m_isolate);

if (tryCatch.HasCaught()) {

v8::Local<v8::Message> message = tryCatch.Message();

if (!message.IsEmpty()) {