Source/bindings/core/v8/ScriptStreamerTest.cpp - Issue 929953002: CachedMetadata support for ServiceWorker script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptStreamerTest.cpp

Issue 929953002: CachedMetadata support for ServiceWorker script. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: incorporated tkent's comment Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/ScriptStreamerTest.cpp

diff --git a/Source/bindings/core/v8/ScriptStreamerTest.cpp b/Source/bindings/core/v8/ScriptStreamerTest.cpp

index 652c010be7fc5bba9b864856ba5facd9908f5074..ec1dfd519b3276244ac793caad9d25b7520ec469 100644

--- a/Source/bindings/core/v8/ScriptStreamerTest.cpp

+++ b/Source/bindings/core/v8/ScriptStreamerTest.cpp

@@ -241,7 +241,9 @@ TEST_F(ScriptStreamingTest, SuppressingStreaming)

appendData("function foo() {");

appendPadding();

- m_resource->setCachedMetadata(V8ScriptRunner::tagForCodeCache(m_resource), "X", 1, Resource::CacheLocally);

+ CachedMetadataHandler* cacheHandler = m_resource->cacheHandler();

+ EXPECT_TRUE(cacheHandler);

+ cacheHandler->setCachedMetadata(V8ScriptRunner::tagForCodeCache(cacheHandler), "X", 1, CachedMetadataHandler::CacheLocally);

appendPadding();

finish();

« no previous file with comments | « Source/bindings/core/v8/ScriptStreamer.cpp ('k') | Source/bindings/core/v8/V8ScriptRunner.h » ('j') | no next file with comments »