Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Issue 929453002: <webview> + <extensionview>: Create a maybeHandleMutation call into attributes (Closed)

Created:
5 years, 10 months ago by Fady Samuel
Modified:
5 years, 10 months ago
Reviewers:
paulmeyer, apacible
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

<webview> + <extensionview>: Create a maybeHandleMutation call into attributes web_view.js and extension_view.js call into maybeHandleMutation which will call handleMutation if the mutation is not set to be ignored. This removes access to the ignoreMutation field outside of attribute objects. This CL also fixes a bug in extensionview src attribute where it does not access the ignoreMutation field properly. BUG=none TBR=lazyboy@chromium.org Committed: https://crrev.com/75868fc9ef79b39e63c7069d4ba95b24489f31e5 Cr-Commit-Position: refs/heads/master@{#316273}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M extensions/renderer/resources/guest_view/extension_view.js View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/resources/guest_view/extension_view_attributes.js View 1 2 chunks +10 lines, -3 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view.js View 1 chunk +2 lines, -3 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view_attributes.js View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Fady Samuel
+paulmeyer@ for web_view* changes +apacible@ for extension_view* changes. Thanks!
5 years, 10 months ago (2015-02-13 17:10:45 UTC) #2
Fady Samuel
5 years, 10 months ago (2015-02-13 17:18:09 UTC) #4
apacible
lgtm extension_view* lgtm Thanks!
5 years, 10 months ago (2015-02-13 18:21:22 UTC) #5
paulmeyer
web_view* LGTM!
5 years, 10 months ago (2015-02-13 18:29:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929453002/20001
5 years, 10 months ago (2015-02-13 19:18:02 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-13 19:18:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929453002/20001
5 years, 10 months ago (2015-02-13 19:21:40 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-13 20:27:27 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 20:27:58 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/75868fc9ef79b39e63c7069d4ba95b24489f31e5
Cr-Commit-Position: refs/heads/master@{#316273}

Powered by Google App Engine
This is Rietveld 408576698