extensions/renderer/resources/guest_view/web_view.js - Issue 929453002: <webview> + <extensionview>: Create a maybeHandleMutation call into attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/guest_view/web_view.js

Issue 929453002: <webview> + <extensionview>: Create a maybeHandleMutation call into attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/renderer/resources/guest_view/extension_view_attributes.js ('k') | extensions/renderer/resources/guest_view/web_view_attributes.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/resources/guest_view/web_view.js

diff --git a/extensions/renderer/resources/guest_view/web_view.js b/extensions/renderer/resources/guest_view/web_view.js

index bc31e25ec58ffbcadd014c26a0095a0c84a426f8..e5fc2702b69aecc5ef6057b372790c43ef3cc1a4 100644

--- a/extensions/renderer/resources/guest_view/web_view.js

+++ b/extensions/renderer/resources/guest_view/web_view.js

@@ -107,13 +107,12 @@ WebViewImpl.prototype.setupElementProperties = function() {

// This observer monitors mutations to attributes of the <webview>.

WebViewImpl.prototype.handleAttributeMutation = function(

attributeName, oldValue, newValue) {

- if (!this.attributes[attributeName] ||

- this.attributes[attributeName].ignoreMutation) {

+ if (!this.attributes[attributeName]) {

return;

}

// Let the changed attribute handle its own mutation;

- this.attributes[attributeName].handleMutation(oldValue, newValue);

+ this.attributes[attributeName].maybeHandleMutation(oldValue, newValue);

};

WebViewImpl.prototype.onSizeChanged = function(webViewEvent) {