extensions/renderer/resources/guest_view/extension_view.js - Issue 929453002: <webview> + <extensionview>: Create a maybeHandleMutation call into attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/guest_view/extension_view.js

Issue 929453002: <webview> + <extensionview>: Create a maybeHandleMutation call into attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/resources/guest_view/extension_view.js

diff --git a/extensions/renderer/resources/guest_view/extension_view.js b/extensions/renderer/resources/guest_view/extension_view.js

index fc560ff349f7d575407f9b0de442063181d4475c..8ca6dfecd1feebea94c73340f3cb99f3f83d0ebb 100644

--- a/extensions/renderer/resources/guest_view/extension_view.js

+++ b/extensions/renderer/resources/guest_view/extension_view.js

@@ -52,7 +52,7 @@ ExtensionViewImpl.prototype.handleAttributeMutation = function(

return;

// Let the changed attribute handle its own mutation;

- this.attributes[attributeName].handleMutation(oldValue, newValue);

+ this.attributes[attributeName].maybeHandleMutation(oldValue, newValue);

};

ExtensionViewImpl.prototype.onElementDetached = function() {

@@ -63,4 +63,4 @@ ExtensionViewImpl.prototype.onElementDetached = function() {

GuestViewContainer.registerElement(ExtensionViewImpl);

// Exports.

-exports.ExtensionViewImpl = ExtensionViewImpl;

+exports.ExtensionViewImpl = ExtensionViewImpl;

« no previous file with comments | « no previous file | extensions/renderer/resources/guest_view/extension_view_attributes.js » ('j') | no next file with comments »