Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 929223003: Move and rename RenderFrame and RenderFrameSet. (Closed)

Created:
5 years, 10 months ago by mstensho (USE GERRIT)
Modified:
5 years, 10 months ago
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-html_chromium.org, eae+blinkwatch, leviw+renderwatch, slimming-paint-reviews_chromium.org, Dominik Röttsches, dglazkov+blink, blink-reviews-rendering, jchaffraix+rendering, blink-reviews-paint_chromium.org, dshwang
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move and rename RenderFrame and RenderFrameSet. RenderFrame -> LayoutFrame RenderFrameSet -> LayoutFrameSet BUG=450612 TBR=dsinclair@chromium.org,jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190311

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+784 lines, -1596 lines) Patch
M LayoutTests/compositing/framesets/composited-frame-alignment-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/frames/002-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/frames/calculate-fixed-expected.txt View 1 chunk +58 lines, -58 lines 0 comments Download
M LayoutTests/fast/frames/calculate-order-expected.txt View 1 chunk +23 lines, -23 lines 0 comments Download
M LayoutTests/fast/frames/calculate-percentage-expected.txt View 1 chunk +38 lines, -38 lines 0 comments Download
M LayoutTests/fast/frames/calculate-relative-expected.txt View 1 chunk +31 lines, -31 lines 0 comments Download
M LayoutTests/fast/frames/calculate-round-expected.txt View 1 chunk +75 lines, -75 lines 0 comments Download
M LayoutTests/fast/frames/empty-cols-attribute-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/frames/empty-frame-src-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/frames/frame-length-fractional-expected.txt View 1 chunk +13 lines, -13 lines 0 comments Download
M LayoutTests/fast/frames/frame-set-rotation-hit-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/frames/frame-set-scaling-3d-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/frames/frame-set-scaling-centered-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/frames/frame-set-scaling-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/frames/frame-set-scaling-hit-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/frames/frame-set-scaling-rotate-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/frames/frame-set-scaling-skew-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/frames/frame-set-whitespace-attributes.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/frames/frame-set-whitespace-attributes-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/frames/invalid-expected.txt View 1 chunk +43 lines, -43 lines 0 comments Download
M LayoutTests/fast/frames/negative-remaining-length-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/frames/no-frame-borders-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/frames/valid-expected.txt View 1 chunk +43 lines, -43 lines 0 comments Download
M LayoutTests/fast/tokenizer/script-after-frameset-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/android/fast/frames/calculate-fixed-expected.txt View 1 chunk +53 lines, -53 lines 0 comments Download
M LayoutTests/platform/android/fast/frames/calculate-order-expected.txt View 1 chunk +18 lines, -18 lines 0 comments Download
M LayoutTests/platform/android/fast/frames/calculate-percentage-expected.txt View 1 chunk +35 lines, -35 lines 0 comments Download
M LayoutTests/platform/android/fast/frames/calculate-relative-expected.txt View 1 chunk +29 lines, -29 lines 0 comments Download
M LayoutTests/platform/android/fast/frames/frame-scrolling-attribute-expected.txt View 8 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/platform/android/fast/frames/frame-set-rotation-hit-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/android/fast/frames/inline-object-inside-frameset-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/android/fast/frames/invalid-expected.txt View 1 chunk +43 lines, -43 lines 0 comments Download
M LayoutTests/platform/android/fast/frames/valid-expected.txt View 1 chunk +43 lines, -43 lines 0 comments Download
M LayoutTests/platform/linux/fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/linux/fast/frames/frame-navigation-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/linux/fast/frames/frame-scrolling-attribute-expected.txt View 8 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/platform/linux/fast/frames/frameElement-frame-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/fast/frames/frameset-style-recalc-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/linux/fast/frames/inline-object-inside-frameset-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/mac/fast/frames/frame-navigation-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/mac/fast/frames/frame-scrolling-attribute-expected.txt View 8 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/platform/mac/fast/frames/frameElement-frame-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/fast/frames/frameset-style-recalc-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/mac/fast/frames/inline-object-inside-frameset-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/loader/text-document-wrapping-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/frames/frame-navigation-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/frames/frame-scrolling-attribute-expected.txt View 8 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/frames/frameElement-frame-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/frames/frameset-style-recalc-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/frames/inline-object-inside-frameset-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/win/fast/frames/frame-navigation-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/win/fast/frames/frame-scrolling-attribute-expected.txt View 8 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/platform/win/fast/frames/frame-set-rotation-hit-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/win/fast/frames/frameElement-frame-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/frames/frameset-style-recalc-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/win/fast/frames/inline-object-inside-frameset-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/loader/text-document-wrapping-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/core.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLFrameElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFrameSetElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
A + Source/core/layout/LayoutFrame.h View 1 chunk +8 lines, -8 lines 0 comments Download
A + Source/core/layout/LayoutFrame.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
A + Source/core/layout/LayoutFrameSet.h View 5 chunks +10 lines, -10 lines 0 comments Download
A + Source/core/layout/LayoutFrameSet.cpp View 18 chunks +33 lines, -31 lines 0 comments Download
M Source/core/layout/LayoutPart.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/FrameSetPainter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/paint/FrameSetPainter.cpp View 3 chunks +19 lines, -19 lines 0 comments Download
D Source/core/rendering/RenderFrame.h View 1 chunk +0 lines, -50 lines 0 comments Download
D Source/core/rendering/RenderFrame.cpp View 1 chunk +0 lines, -50 lines 0 comments Download
D Source/core/rendering/RenderFrameSet.h View 1 chunk +0 lines, -139 lines 0 comments Download
D Source/core/rendering/RenderFrameSet.cpp View 1 chunk +0 lines, -575 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
mstensho (USE GERRIT)
5 years, 10 months ago (2015-02-17 11:00:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929223003/1
5 years, 10 months ago (2015-02-17 11:01:32 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 12:20:37 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190311

Powered by Google App Engine
This is Rietveld 408576698