Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: public/platform/WebLayerTreeView.h

Issue 929213004: Plumb selection bounds as a single unit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: TODO for moving WebSelectionBound Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/web.gypi ('k') | public/platform/WebSelectionBound.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebLayerTreeView.h
diff --git a/public/platform/WebLayerTreeView.h b/public/platform/WebLayerTreeView.h
index af13fc7fd08505b4b2a320816b345e45f94df845..afc35caa88353d17dd1f0829579c378f74bee743 100644
--- a/public/platform/WebLayerTreeView.h
+++ b/public/platform/WebLayerTreeView.h
@@ -43,6 +43,7 @@ class WebCompositorAnimationTimeline;
class WebLayer;
struct WebPoint;
struct WebSelectionBound;
+class WebSelection;
class WebWidget;
class WebLayerTreeView {
@@ -133,10 +134,9 @@ public:
virtual void clearViewportLayers() { }
// Used to update the active selection bounds.
- // If the (empty) selection is an insertion point, |start| and |end| will be identical with type |Caret|.
- // If the (non-empty) selection has mixed RTL/LTR text, |start| and |end| may share the same type,
- // |SelectionLeft| or |SelectionRight|.
+ // FIXME: Remove this overload when downstream consumers have been updated to use WebSelection, crbug.com/466672.
virtual void registerSelection(const WebSelectionBound& start, const WebSelectionBound& end) { }
+ virtual void registerSelection(const WebSelection&) { }
virtual void clearSelection() { }
// Debugging / dangerous ---------------------------------------------
« no previous file with comments | « Source/web/web.gypi ('k') | public/platform/WebSelectionBound.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698