Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: public/platform/WebSelectionBound.h

Issue 929213004: Plumb selection bounds as a single unit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: TODO for moving WebSelectionBound Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « public/platform/WebLayerTreeView.h ('k') | public/web/WebSelection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebSelectionBound.h
diff --git a/public/platform/WebSelectionBound.h b/public/platform/WebSelectionBound.h
index bdedd3636e685e4a8cff8b5c1e863b384057f490..08609de94cbd6324157cb3c1d917e721b092d17b 100644
--- a/public/platform/WebSelectionBound.h
+++ b/public/platform/WebSelectionBound.h
@@ -10,7 +10,10 @@
namespace blink {
// An endpoint for an active selection region.
+// TODO(jdduke): Move this to web/ after downstream code adopts |WebSelection|.
struct WebSelectionBound {
+ // TODO(jdduke): Remove the type identifier after downstream code adopts
+ // |WebSelection| for determining bound orientation.
enum Type {
Caret,
SelectionLeft,
@@ -20,6 +23,7 @@ struct WebSelectionBound {
explicit WebSelectionBound(Type type)
: type(type)
, layerId(0)
+ , isTextDirectionRTL(false)
{
}
@@ -34,6 +38,9 @@ struct WebSelectionBound {
// that define the selection bound.
WebPoint edgeTopInLayer;
WebPoint edgeBottomInLayer;
+
+ // Whether the text direction at this location is RTL.
+ bool isTextDirectionRTL;
};
} // namespace blink
« no previous file with comments | « public/platform/WebLayerTreeView.h ('k') | public/web/WebSelection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698