[KeyboardEvent] Add embedder APIs to translate between Dom |key| enum and strings

content/browser/renderer_host/web_input_event_aura.cc

Index: content/browser/renderer_host/web_input_event_aura.cc
diff --git a/content/browser/renderer_host/web_input_event_aura.cc b/content/browser/renderer_host/web_input_event_aura.cc
index b09f67e680220fd00d9726e98172ef2b9a523e94..4eb0f992382b0b3ba492deb1e64ef459feef0723 100644
--- a/content/browser/renderer_host/web_input_event_aura.cc
+++ b/content/browser/renderer_host/web_input_event_aura.cc
@@ -85,6 +85,9 @@ blink::WebKeyboardEvent MakeWebKeyboardEventFromAuraEvent(
   webkit_event.nativeKeyCode =
     ui::KeycodeConverter::DomCodeToNativeKeycode(event.code());
   webkit_event.domCode = static_cast<int>(event.code());
+  webkit_event.domKey  = static_cast<int>(event.GetDomKey());

[dtapuska, 2015/06/18 14:28:30]

These methods do not trap the KEY_PRESSED events that are generated via
NativeWebKeyboardEvent (see native_web_keyboard_event_aura.cc line 60).

They only trap the native events from the env; but the key_pressed event is
generated is it not?

(I'm currently looking into http://crbug.com/428018 where the old
"keyIdentifier" is generated incorrectly because of the conflated windows key. I
was wondering if I could change it's generation based on the dom code; but it
seems that you aren't populating that at all either.

[Wez, 2015/06/25 10:40:21]

As discussed, keyIdentifier is deprecated and should be removed, and even when
it was part of the DOM Level 3 spec it didn't apply to keypress events.
Similarly the DOM |code| field does not apply to keypress events - I believe
that |key| is currently specified as being present on keypress events, though
its presence is questionable since keypress itself is a legacy-compatibility
event.

+  webkit_event.domKeyChar = static_cast<int>(event.GetCharacter());
+
   webkit_event.unmodifiedText[0] = event.GetUnmodifiedText();
   webkit_event.text[0] = event.GetText();
 
@@ -276,6 +279,8 @@ blink::WebKeyboardEvent MakeWebKeyboardEvent(const ui::KeyEvent& event) {
     blink::WebKeyboardEvent webkit_event(
         MakeWebKeyboardEventFromNativeEvent(event.native_event()));
     webkit_event.domCode = static_cast<int>(event.code());
+    webkit_event.domKey  = static_cast<int>(event.GetDomKey());
+    webkit_event.domKeyChar = static_cast<int>(event.GetCharacter());
     return webkit_event;
   }
 #endif