[KeyboardEvent] Add embedder APIs to translate between Dom |key| enum and strings

content/browser/renderer_host/web_input_event_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/web_input_event_aura.h"
 
 #include "content/browser/renderer_host/input/web_input_event_util.h"
 #include "content/browser/renderer_host/ui_events_helper.h"
 #include "ui/aura/client/screen_position_client.h"
 #include "ui/aura/window.h"
@@ skipping 67 matching lines @@
       NOTREACHED();
   }
 
   if (webkit_event.modifiers & blink::WebInputEvent::AltKey)
     webkit_event.isSystemKey = true;
 
   webkit_event.windowsKeyCode = event.GetLocatedWindowsKeyboardCode();
   webkit_event.nativeKeyCode =
     ui::KeycodeConverter::DomCodeToNativeKeycode(event.code());
   webkit_event.domCode = static_cast<int>(event.code());
+  webkit_event.domKey  = static_cast<int>(event.GetDomKey());

[dtapuska, 2015/06/18 14:28:30]

These methods do not trap the KEY_PRESSED events that are generated via
NativeWebKeyboardEvent (see native_web_keyboard_event_aura.cc line 60).

They only trap the native events from the env; but the key_pressed event is
generated is it not?

(I'm currently looking into http://crbug.com/428018 where the old
"keyIdentifier" is generated incorrectly because of the conflated windows key. I
was wondering if I could change it's generation based on the dom code; but it
seems that you aren't populating that at all either.

[Wez, 2015/06/25 10:40:21]

As discussed, keyIdentifier is deprecated and should be removed, and even when
it was part of the DOM Level 3 spec it didn't apply to keypress events.
Similarly the DOM |code| field does not apply to keypress events - I believe
that |key| is currently specified as being present on keypress events, though
its presence is questionable since keypress itself is a legacy-compatibility
event.

+  webkit_event.domKeyChar = static_cast<int>(event.GetCharacter());
+
   webkit_event.unmodifiedText[0] = event.GetUnmodifiedText();
   webkit_event.text[0] = event.GetText();
 
   webkit_event.setKeyIdentifierFromWindowsKeyCode();
 
   return webkit_event;
 }
 
 blink::WebMouseWheelEvent MakeWebMouseWheelEventFromAuraEvent(
     const ui::ScrollEvent& event) {
@@ skipping 171 matching lines @@
   // event.native_event(). X11 is not so fortunate, there is no separate
   // translated event type, so DesktopHostLinux sends an extra KeyEvent with
   // is_char() == true. We need to pass the ui::KeyEvent to the X11 function
   // to detect this case so the right event type can be constructed.
 #if defined(OS_WIN)
   if (event.HasNativeEvent()) {
     // Key events require no translation by the aura system.
     blink::WebKeyboardEvent webkit_event(
         MakeWebKeyboardEventFromNativeEvent(event.native_event()));
     webkit_event.domCode = static_cast<int>(event.code());
+    webkit_event.domKey  = static_cast<int>(event.GetDomKey());
+    webkit_event.domKeyChar = static_cast<int>(event.GetCharacter());
     return webkit_event;
   }
 #endif
   return MakeWebKeyboardEventFromAuraEvent(event);
 }
 
 blink::WebGestureEvent MakeWebGestureEvent(const ui::GestureEvent& event) {
   blink::WebGestureEvent gesture_event;
 #if defined(OS_WIN)
   if (event.HasNativeEvent())
@@ skipping 106 matching lines @@
     webkit_event.deltaY = event.y_offset();
   }
 
   webkit_event.wheelTicksX = webkit_event.deltaX / kPixelsPerTick;
   webkit_event.wheelTicksY = webkit_event.deltaY / kPixelsPerTick;
 
   return webkit_event;
 }
 
 }  // namespace content