content/child/blink_platform_impl.h - Issue 929053004: [KeyboardEvent] Add embedder APIs to translate between Dom |key| enum and strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/blink_platform_impl.h

Issue 929053004: [KeyboardEvent] Add embedder APIs to translate between Dom |key| enum and strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a new parameter to pass DOM |key| character Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/web_input_event_aura.cc ('K') | « content/browser/renderer_host/web_input_event_aura_unittest.cc ('k') | content/child/blink_platform_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/blink_platform_impl.h

diff --git a/content/child/blink_platform_impl.h b/content/child/blink_platform_impl.h

index 178bfb6a11251bb3c3d9a2db1b07503f4ea90516..9671f4300b2eb12de887188724573e5e22829fd5 100644

--- a/content/child/blink_platform_impl.h

+++ b/content/child/blink_platform_impl.h

@@ -179,6 +179,9 @@ class CONTENT_EXPORT BlinkPlatformImpl

virtual blink::WebString domCodeStringFromEnum(int dom_code);

virtual int domEnumFromCodeString(const blink::WebString& codeString);

Wez 2015/06/11 00:09:05 code_string (see below)

Habib Virji 2015/06/24 14:32:12 Done.

+ virtual blink::WebString domKeyStringFromEnum(int dom_key);

+ virtual int domKeyEnumFromString(const blink::WebString& keyString);

Wez 2015/06/11 00:09:05 Sorry, in Chromium-style this should be key_string

Habib Virji 2015/06/24 14:32:12 Done.

private:

void DoTimeout() {

if (shared_timer_func_ && !shared_timer_suspended_)