Issue 92903002: CQ: include more information in exception warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 92903002: CQ: include more information in exception warnings (Closed)

Created:
7 years ago by Paweł Hajdan Jr.

Modified:
7 years ago

Reviewers:
cmp

CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/

Visibility:
Public.

More Reviews

Description

CQ: include more information in exception warnings BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=237633

Patch Set 1 #

Total comments: 2

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	commit-queue/verification/try_job_on_rietveld.py	View		1 chunk	+8 lines, -3 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

cmp

https://codereview.chromium.org/92903002/diff/1/commit-queue/verification/try_job_on_rietveld.py File commit-queue/verification/try_job_on_rietveld.py (right): https://codereview.chromium.org/92903002/diff/1/commit-queue/verification/try_job_on_rietveld.py#newcode738 commit-queue/verification/try_job_on_rietveld.py:738: str(e), str(pending.issue))) let's add e.url to the message here, ...

7 years ago (2013-11-27 22:17:16 UTC) #2

cmp

On 2013/11/27 22:22:52, cmp wrote: > lgtm without those changes why: The code is complicated, ...

7 years ago (2013-11-27 22:23:20 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/92903002/1

7 years ago (2013-11-27 22:26:29 UTC) #5

Message was sent while issue was closed.

Change committed as 237633

Expand Messages | Collapse Messages