CQ: include more information in exception warnings

commit-queue/verification/try_job_on_rietveld.py

 # coding=utf8
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Sends patches to the Try server and reads back results.
 
 - RietveldTryJobs contains RietveldTryJob, one per try job on a builder.
 - TryRunnerRietveld uses Rietveld to signal and poll job results.
 """
 
@@ skipping 707 matching lines @@
 
       # Update the RietvedTryJobs object.
       keys = jobs.update_jobs_from_rietveld(
           data,
           status,
           self.context.checkout,
           now)
     except urllib2.HTTPError as e:
       if e.code in (500, 502, 503):
         # Temporary AppEngine hiccup. Just log it and return failure.
-        logging.warning(str(e))
+        logging.warning('%s while accessing %s. Ignoring error.' % (
+                        str(e), e.url))
         return False
       else:
         raise
     except socket.error as e:
       # Temporary AppEngine hiccup. Just log it and return failure.
       if e.errno == errno.ECONNRESET:
-        logging.warning(str(e))
+        logging.warning(
+            '%s while updating tryserver status for rietveld issue %s.' % (
+            str(e), str(pending.issue)))

[cmp, 2013/11/27 22:17:16]

let's add e.url to the message here, too

         return False
       else:
         raise
     except IOError as e:
       # Temporary AppEngine hiccup. Just log it and return failure.
       if e.errno == 'socket error':
-        logging.warning(str(e))
+        logging.warning(
+            '%s while updating tryserver status for rietveld issue %s.' % (
+            str(e), str(pending.issue)))

[cmp, 2013/11/27 22:17:16]

let's add e.url to the message here, too

         return False
       raise
     if handle:
       for updated_key in keys:
         job = jobs.try_jobs[updated_key]
         self._update_dashboard(pending, job, status)
         jobs.signal_as_failed_if_needed(job, self._build_status_url(job), now)
 
     return True