Chromium Code Reviews| Index: commit-queue/verification/try_job_on_rietveld.py |
| =================================================================== |
| --- commit-queue/verification/try_job_on_rietveld.py (revision 237625) |
| +++ commit-queue/verification/try_job_on_rietveld.py (working copy) |
| @@ -725,21 +725,26 @@ |
| except urllib2.HTTPError as e: |
| if e.code in (500, 502, 503): |
| # Temporary AppEngine hiccup. Just log it and return failure. |
| - logging.warning(str(e)) |
| + logging.warning('%s while accessing %s. Ignoring error.' % ( |
| + str(e), e.url)) |
| return False |
| else: |
| raise |
| except socket.error as e: |
| # Temporary AppEngine hiccup. Just log it and return failure. |
| if e.errno == errno.ECONNRESET: |
| - logging.warning(str(e)) |
| + logging.warning( |
| + '%s while updating tryserver status for rietveld issue %s.' % ( |
| + str(e), str(pending.issue))) |
|
cmp
2013/11/27 22:17:16
let's add e.url to the message here, too
|
| return False |
| else: |
| raise |
| except IOError as e: |
| # Temporary AppEngine hiccup. Just log it and return failure. |
| if e.errno == 'socket error': |
| - logging.warning(str(e)) |
| + logging.warning( |
| + '%s while updating tryserver status for rietveld issue %s.' % ( |
| + str(e), str(pending.issue))) |
|
cmp
2013/11/27 22:17:16
let's add e.url to the message here, too
|
| return False |
| raise |
| if handle: |