Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: commit-queue/verification/try_job_on_rietveld.py

Issue 92903002: CQ: include more information in exception warnings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: commit-queue/verification/try_job_on_rietveld.py
===================================================================
--- commit-queue/verification/try_job_on_rietveld.py (revision 237625)
+++ commit-queue/verification/try_job_on_rietveld.py (working copy)
@@ -725,21 +725,26 @@
except urllib2.HTTPError as e:
if e.code in (500, 502, 503):
# Temporary AppEngine hiccup. Just log it and return failure.
- logging.warning(str(e))
+ logging.warning('%s while accessing %s. Ignoring error.' % (
+ str(e), e.url))
return False
else:
raise
except socket.error as e:
# Temporary AppEngine hiccup. Just log it and return failure.
if e.errno == errno.ECONNRESET:
- logging.warning(str(e))
+ logging.warning(
+ '%s while updating tryserver status for rietveld issue %s.' % (
+ str(e), str(pending.issue)))
cmp 2013/11/27 22:17:16 let's add e.url to the message here, too
return False
else:
raise
except IOError as e:
# Temporary AppEngine hiccup. Just log it and return failure.
if e.errno == 'socket error':
- logging.warning(str(e))
+ logging.warning(
+ '%s while updating tryserver status for rietveld issue %s.' % (
+ str(e), str(pending.issue)))
cmp 2013/11/27 22:17:16 let's add e.url to the message here, too
return False
raise
if handle:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698