Set the view pointer as NULL after its xfa doc is released

Set the view pointer as NULL after its xfa doc is released

BUG=452794
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/54d8c39002a0f8e3925de888226d22f157987a34

[jun_fang, 2015-02-14 19:30:13]

jun_fang@foxitsoftware.com changed reviewers:
+ kai_jing@foxitsoftware.com, tsepez@chromium.org

[jun_fang, 2015-02-14 19:30:13]

Hi Tom,

Please review this CL. Thanks!

[Tom Sepez, 2015-02-17 19:14:08]

https://codereview.chromium.org/928803002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_...
File fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp (right):

https://codereview.chromium.org/928803002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_...
fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp:81: pDocHandler->CloseDoc(m_pXFADoc);
nit: can we make a helper method to do these 4 steps?  It looks like we do the
same thing in several places?

[Tom Sepez, 2015-02-17 19:14:45]

Also, typo NULl in title/description.

[Tom Sepez, 2015-02-17 19:23:00]

https://codereview.chromium.org/928803002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_...
File fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp (right):

https://codereview.chromium.org/928803002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_...
fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp:18: #define IDS_XFA_StringMonth_April
"April"
Unrelated: curious, what happened to January, February, and March?
git grep shows these unused, remove at your convenience.

[jun_fang, 2015-02-17 20:31:53]

On 2015/02/17 19:23:00, Tom Sepez wrote:
>
https://codereview.chromium.org/928803002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_...
> File fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp (right):
> 
>
https://codereview.chromium.org/928803002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_...
> fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp:18: #define IDS_XFA_StringMonth_April
> "April"
> Unrelated: curious, what happened to January, February, and March?
> git grep shows these unused, remove at your convenience.

I added a helper function and removed the unused macro. Please reviw these
changes again. Thanks!

[Tom Sepez, 2015-02-17 20:37:24]

lgtm

https://codereview.chromium.org/928803002/diff/20001/fpdfsdk/include/fpdfxfa/...
File fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h (right):

https://codereview.chromium.org/928803002/diff/20001/fpdfsdk/include/fpdfxfa/...
fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h:131: void		CloseXFADoc(IXFA_DocHandler*
pDoc) {
nit: I'd put the implementation into the .cpp file.  It's private, and local to
the one file, so we'd expect the compiler to do a good job of optimizing it

[jun_fang, 2015-02-17 20:55:02]

Committed patchset #2 (id:20001) manually as
54d8c39002a0f8e3925de888226d22f157987a34 (presubmit successful).