Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 928803002: Set the view pointer as NULL after its xfa doc is released (Closed)

Created:
5 years, 10 months ago by jun_fang
Modified:
5 years, 10 months ago
Reviewers:
Tom Sepez, kai_jing
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set the view pointer as NULL after its xfa doc is released BUG=452794 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/54d8c39002a0f8e3925de888226d22f157987a34

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -25 lines) Patch
M fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h View 1 3 chunks +10 lines, -1 line 1 comment Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp View 1 4 chunks +3 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
jun_fang
Hi Tom, Please review this CL. Thanks!
5 years, 10 months ago (2015-02-14 19:30:13 UTC) #2
Tom Sepez
https://codereview.chromium.org/928803002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp File fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp (right): https://codereview.chromium.org/928803002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp#newcode81 fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp:81: pDocHandler->CloseDoc(m_pXFADoc); nit: can we make a helper method to ...
5 years, 10 months ago (2015-02-17 19:14:08 UTC) #3
Tom Sepez
Also, typo NULl in title/description.
5 years, 10 months ago (2015-02-17 19:14:45 UTC) #4
Tom Sepez
https://codereview.chromium.org/928803002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp File fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp (right): https://codereview.chromium.org/928803002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp#newcode18 fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp:18: #define IDS_XFA_StringMonth_April "April" Unrelated: curious, what happened to January, ...
5 years, 10 months ago (2015-02-17 19:23:00 UTC) #5
jun_fang
On 2015/02/17 19:23:00, Tom Sepez wrote: > https://codereview.chromium.org/928803002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp > File fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp (right): > > https://codereview.chromium.org/928803002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp#newcode18 ...
5 years, 10 months ago (2015-02-17 20:31:53 UTC) #6
Tom Sepez
lgtm https://codereview.chromium.org/928803002/diff/20001/fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h File fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h (right): https://codereview.chromium.org/928803002/diff/20001/fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h#newcode131 fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h:131: void CloseXFADoc(IXFA_DocHandler* pDoc) { nit: I'd put the ...
5 years, 10 months ago (2015-02-17 20:37:24 UTC) #7
jun_fang
5 years, 10 months ago (2015-02-17 20:55:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
54d8c39002a0f8e3925de888226d22f157987a34 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698