Set the view pointer as NULL after its xfa doc is released

fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef _FPDFXFA_DOC_H_
 #define _FPDFXFA_DOC_H_
 
 class CPDFXFA_App;
 class CPDFXFA_Document;
 class CPDFXFA_Page;
 class CPDFSDK_Document;
 class CPDFDoc_Environment;
 class IFXJS_Runtime;
 class IFXJS_Context;
+class IXFA_DocHandler;
 
 class CPDFXFA_Document : public IXFA_DocProvider, public CFX_Object
 {
 public:
         CPDFXFA_Document(CPDF_Document* pPDFDoc, CPDFXFA_App* pProvider);
         ~CPDFXFA_Document();
 
         FX_BOOL                         LoadXFADoc();
-        void                            CloseXFADoc();
         CPDFXFA_App*            GetApp() {return m_pApp;}
         CPDF_Document*          GetPDFDoc() { return m_pPDFDoc; }
         XFA_HDOC                        GetXFADoc() { return m_pXFADoc; }
         IXFA_DocView*       GetXFADocView() { return m_pXFADocView; }
 
         int                                     GetPageCount();
         CPDFXFA_Page*           GetPage(int page_index);
         CPDFXFA_Page*           GetPage(IXFA_PageView* pPage);
         void                            RemovePage(CPDFXFA_Page* page);
         int                                     GetDocType(){ return m_iDocType; }
@@ skipping 85 matching lines @@
         FX_BOOL         _OnBeforeNotifySumbit();
         void            _OnAfterNotifySumbit();
         FX_BOOL         _NotifySubmit(FX_BOOL bPrevOrPost);
         FX_BOOL         _SubmitData(XFA_HDOC hDoc, CXFA_Submit submit);
         FX_BOOL         _MailToInfo(CFX_WideString& csURL, CFX_WideString& csToAddress, CFX_WideString& csCCAddress, CFX_WideString& csBCCAddress, CFX_WideString& csSubject, CFX_WideString& csMsg);
         FX_BOOL         _ExportSubmitFile(FPDF_FILEHANDLER* ppFileHandler, int fileType, FPDF_DWORD encodeType, FPDF_DWORD flag = 0x01111111);
         void            _ToXFAContentFlags(CFX_WideString csSrcContent, FPDF_DWORD& flag);
         void            _ClearChangeMark();
 
 private:
+        void            CloseXFADoc(IXFA_DocHandler* pDoc) {

[Tom Sepez, 2015/02/17 20:37:24]

nit: I'd put the implementation into the .cpp file.  It's private, and local to
the one file, so we'd expect the compiler to do a good job of optimizing it 

+                                        if (pDoc) {
+                                                pDoc->CloseDoc(m_pXFADoc);
+                                                pDoc->ReleaseDoc(m_pXFADoc);
+                                                m_pXFADoc = NULL;
+                                                m_pXFADocView = NULL;
+                                        }
+                                }
+
         CPDF_Document* m_pPDFDoc;
         XFA_HDOC  m_pXFADoc;
         IXFA_DocView* m_pXFADocView;
         CFX_ArrayTemplate<CPDFXFA_Page*> m_XFAPageList;
 
         CPDFSDK_Document* m_pSDKDoc;
         CPDFXFA_App* m_pApp;
 
         CFX_MapByteStringToPtr  m_XfaGlobalProperty;
 
         CFX_MapByteStringToPtr  m_ValueMap;
 
         IFXJS_Context*                  m_pJSContext;
 
         int                     m_iDocType;
 };
 
 #endif