Set the view pointer as NULL after its xfa doc is released

fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fsdk_define.h"
 #include "../../include/fpdfxfa/fpdfxfa_doc.h"
 #include "../../include/fpdfformfill.h"
 #include "../../include/fsdk_mgr.h"
 #include "../../include/fpdfxfa/fpdfxfa_app.h"
 #include "../../include/fpdfxfa/fpdfxfa_util.h"
 #include "../../include/fpdfxfa/fpdfxfa_page.h"
 #include "../../include/javascript/IJavaScript.h"
 
 
 
 #define IDS_XFA_StringMonth_April "April"

[Tom Sepez, 2015/02/17 19:23:00]

Unrelated: curious, what happened to January, February, and March?
git grep shows these unused, remove at your convenience.

 #define IDS_XFA_StringMonth_May "May"
 #define IDS_XFA_StringMonth_June "June"
 #define IDS_XFA_StringMonth_July "July"
 #define IDS_XFA_StringMonth_Aug "August"
 #define IDS_XFA_StringMonth_Sept "September"
 #define IDS_XFA_StringMonth_Oct "October"
 #define IDS_XFA_StringMonth_Nov "November"
 #define IDS_XFA_StringMonth_Dec "December"
 #define IDS_XFA_String_Today    "Today"
 #define IDS_XFA_ValidateLimit   "Message limit exceeded. Remaining %d validation errors not reported."
@@ skipping 42 matching lines @@
                 m_pPDFDoc = NULL;
         }
         if (m_pXFADoc)
         {
                 IXFA_App* pApp = m_pApp->GetXFAApp();
                 if (pApp) 
                 {
                         IXFA_DocHandler* pDocHandler = pApp->GetDocHandler();
                         if (pDocHandler)
                         {
                                 pDocHandler->CloseDoc(m_pXFADoc);

[Tom Sepez, 2015/02/17 19:14:08]

nit: can we make a helper method to do these 4 steps?  It looks like we do the
same thing in several places?

                                 pDocHandler->ReleaseDoc(m_pXFADoc);
                                 m_pXFADoc = NULL;
+                                m_pXFADocView = NULL;
                         }       
                 }
         }
 
         if (m_pJSContext)
         {
                 if (m_pSDKDoc && m_pSDKDoc->GetEnv())
                 {
                         m_pSDKDoc->GetEnv()->GetJSRuntime()->ReleaseContext(m_pJSContext);
                         m_pJSContext = NULL;
@@ skipping 31 matching lines @@
                         IXFA_DocHandler* pDocHandler = pApp->GetDocHandler();
                         if (pDocHandler)
                         {
                                 int iStatus = pDocHandler->StartLoad(m_pXFADoc);
                                 iStatus = pDocHandler->DoLoad(m_pXFADoc, NULL);
                                 if (iStatus != 100) 
                                 {
                                         pDocHandler->CloseDoc(m_pXFADoc);
                                         pDocHandler->ReleaseDoc(m_pXFADoc);
                                         m_pXFADoc = NULL;
+                                        m_pXFADocView = NULL;
 
                                         SetLastError(FPDF_ERR_XFALOAD);
                                         return FALSE;
                                 }
                                 pDocHandler->StopLoad(m_pXFADoc);
                                 pDocHandler->SetJSERuntime(m_pXFADoc, m_pApp->GetJSERuntime());
 
                                 if (pDocHandler->GetDocType(m_pXFADoc) == XFA_DOCTYPE_Dynamic)
                                         m_iDocType = DOCTYPE_DYNIMIC_XFA;
                                 else
                                         m_iDocType = DOCTYPE_STATIC_XFA;
 
                                 m_pXFADocView = pDocHandler->CreateDocView(m_pXFADoc, XFA_DOCVIEW_View);
                                 FXSYS_assert(m_pXFADocView);
 
                                 if (m_pXFADocView->StartLayout() < 0) 
                                 {
                                         pDocHandler->CloseDoc(m_pXFADoc);
                                         pDocHandler->ReleaseDoc(m_pXFADoc);
                                         m_pXFADoc = NULL;
+                                        m_pXFADocView = NULL;
 
                                         SetLastError(FPDF_ERR_XFALAYOUT);
                                         return FALSE;
                                 }
                                 else
                                 {
                                         m_pXFADocView->DoLayout(NULL);
                                         m_pXFADocView->StopLayout();
 
                                         return TRUE;
@@ skipping 1302 matching lines @@
         }
 
         return _GetHValueByName(szPropName, hValue, m_pSDKDoc->GetEnv()->GetJSRuntime());
 
 }
 FX_BOOL CPDFXFA_Document::_GetHValueByName(FX_BSTR utf8Name, FXJSE_HVALUE hValue, IFXJS_Runtime* runTime)
 {
         return runTime->GetHValueByName(utf8Name, hValue);
 }