Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 928213003: Model exceptional edges from call nodes in TurboFan. (Closed)

Created:
5 years, 10 months ago by Michael Starzinger
Modified:
5 years, 10 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Model exceptional edges from call nodes in TurboFan. R=titzer@chromium.org,bmeurer@chromium.org Committed: https://crrev.com/6881d7609a22eb05b450f626a62259e2e062c543 Cr-Commit-Position: refs/heads/master@{#26766}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments by Benedikt Meurer. #

Total comments: 10

Patch Set 3 : Addressed comments by Ben Titzer. #

Patch Set 4 : Rebased. #

Total comments: 4

Patch Set 5 : Addressed moar comments by Benedikt Meurer. #

Patch Set 6 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+406 lines, -149 lines) Patch
M src/compiler/ast-graph-builder.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 3 4 5 5 chunks +32 lines, -5 lines 0 comments Download
M src/compiler/change-lowering.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/common-operator.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/common-operator.cc View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M src/compiler/control-reducer.cc View 1 2 3 4 5 3 chunks +5 lines, -7 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 3 4 chunks +18 lines, -22 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/compiler/js-operator.cc View 11 chunks +23 lines, -20 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 7 chunks +18 lines, -8 lines 0 comments Download
M src/compiler/node-properties.h View 1 2 3 4 5 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/node-properties.cc View 1 2 3 4 5 4 chunks +18 lines, -7 lines 0 comments Download
M src/compiler/opcodes.h View 1 2 3 2 chunks +8 lines, -2 lines 0 comments Download
M src/compiler/operator.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/schedule.h View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M src/compiler/schedule.cc View 1 2 3 4 5 chunks +20 lines, -7 lines 0 comments Download
M src/compiler/scheduler.cc View 1 2 3 4 5 11 chunks +74 lines, -24 lines 0 comments Download
M src/compiler/verifier.cc View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-jsexceptions.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-operator-unittest.cc View 4 chunks +42 lines, -40 lines 0 comments Download
M test/unittests/compiler/node-properties-unittest.cc View 1 2 3 4 5 2 chunks +57 lines, -0 lines 0 comments Download
M test/unittests/compiler/schedule-unittest.cc View 2 chunks +32 lines, -1 line 0 comments Download

Messages

Total messages: 16 (3 generated)
Michael Starzinger
5 years, 10 months ago (2015-02-16 17:20:09 UTC) #1
Benedikt Meurer
https://codereview.chromium.org/928213003/diff/1/src/compiler/node-properties.cc File src/compiler/node-properties.cc (right): https://codereview.chromium.org/928213003/diff/1/src/compiler/node-properties.cc#newcode163 src/compiler/node-properties.cc:163: if (IsControlEdge(edge)) { Please add a unit test for ...
5 years, 10 months ago (2015-02-17 05:58:49 UTC) #2
Michael Starzinger
https://codereview.chromium.org/928213003/diff/1/src/compiler/node-properties.cc File src/compiler/node-properties.cc (right): https://codereview.chromium.org/928213003/diff/1/src/compiler/node-properties.cc#newcode163 src/compiler/node-properties.cc:163: if (IsControlEdge(edge)) { On 2015/02/17 05:58:48, Benedikt Meurer wrote: ...
5 years, 10 months ago (2015-02-17 10:12:06 UTC) #3
titzer
https://codereview.chromium.org/928213003/diff/20001/src/compiler/common-operator.h File src/compiler/common-operator.h (right): https://codereview.chromium.org/928213003/diff/20001/src/compiler/common-operator.h#newcode179 src/compiler/common-operator.h:179: const Operator* IfSuccess(); IfSuccess first? here and elsewhere. https://codereview.chromium.org/928213003/diff/20001/src/compiler/instruction-selector.cc ...
5 years, 10 months ago (2015-02-17 10:32:52 UTC) #4
Michael Starzinger
https://codereview.chromium.org/928213003/diff/20001/src/compiler/common-operator.h File src/compiler/common-operator.h (right): https://codereview.chromium.org/928213003/diff/20001/src/compiler/common-operator.h#newcode179 src/compiler/common-operator.h:179: const Operator* IfSuccess(); On 2015/02/17 10:32:52, titzer wrote: > ...
5 years, 10 months ago (2015-02-17 10:58:30 UTC) #5
Michael Starzinger
Rebased. PTAL.
5 years, 10 months ago (2015-02-17 15:06:41 UTC) #6
Benedikt Meurer
LGTM with nits. https://codereview.chromium.org/928213003/diff/60001/src/compiler/schedule.cc File src/compiler/schedule.cc (right): https://codereview.chromium.org/928213003/diff/60001/src/compiler/schedule.cc#newcode207 src/compiler/schedule.cc:207: DCHECK(block->control() == BasicBlock::kNone); Nit: Use DCHECK_EQ ...
5 years, 10 months ago (2015-02-17 18:31:39 UTC) #7
Michael Starzinger
https://codereview.chromium.org/928213003/diff/60001/src/compiler/schedule.cc File src/compiler/schedule.cc (right): https://codereview.chromium.org/928213003/diff/60001/src/compiler/schedule.cc#newcode207 src/compiler/schedule.cc:207: DCHECK(block->control() == BasicBlock::kNone); On 2015/02/17 18:31:39, Benedikt Meurer wrote: ...
5 years, 10 months ago (2015-02-18 14:03:57 UTC) #9
Benedikt Meurer
Still LGTM
5 years, 10 months ago (2015-02-19 06:38:06 UTC) #10
titzer
lgtm
5 years, 10 months ago (2015-02-19 11:28:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928213003/100001
5 years, 10 months ago (2015-02-20 09:51:59 UTC) #14
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 10 months ago (2015-02-20 09:54:53 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 09:55:08 UTC) #16
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/6881d7609a22eb05b450f626a62259e2e062c543
Cr-Commit-Position: refs/heads/master@{#26766}

Powered by Google App Engine
This is Rietveld 408576698