Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 927783002: cc: Stop passing the occlusion explicitly to AppendQuads. (Closed)

Created:
5 years, 10 months ago by danakj
Modified:
5 years, 10 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Stop passing the occlusion explicitly to AppendQuads. The occlusion is a draw property, the layer can access it from there like other draw properties. Cleanup CL since moving occlusion to draw properties. Too many AppendQuads overrides... :( R=enne BUG=446751 NOTRY=true Committed: https://crrev.com/a8c66a5d291cc7d3c57572a8498ac5ca392563ec Cr-Commit-Position: refs/heads/master@{#316358}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -126 lines) Patch
M cc/layers/delegated_renderer_layer_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/layers/delegated_renderer_layer_impl.cc View 5 chunks +3 lines, -6 lines 0 comments Download
M cc/layers/heads_up_display_layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/heads_up_display_layer_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/heads_up_display_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/io_surface_layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/io_surface_layer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/nine_patch_layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/nine_patch_layer_impl.cc View 10 chunks +19 lines, -10 lines 0 comments Download
M cc/layers/nine_patch_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/painted_scrollbar_layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/painted_scrollbar_layer_impl.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M cc/layers/picture_image_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/picture_layer_impl.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M cc/layers/solid_color_layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/solid_color_layer_impl.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M cc/layers/solid_color_layer_impl_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M cc/layers/solid_color_scrollbar_layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/solid_color_scrollbar_layer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/surface_layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/surface_layer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/texture_layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/texture_layer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/tiled_layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/tiled_layer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/tiled_layer_impl_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M cc/layers/ui_resource_layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/ui_resource_layer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/ui_resource_layer_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/video_layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/video_layer_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/test/fake_picture_layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/fake_picture_layer_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/test/layer_test_common.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 2 chunks +2 lines, -15 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 4 chunks +2 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_on_demand_raster.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
danakj
5 years, 10 months ago (2015-02-14 00:48:59 UTC) #1
enne (OOO)
lgtm
5 years, 10 months ago (2015-02-14 00:51:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927783002/1
5 years, 10 months ago (2015-02-14 00:52:06 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/25236)
5 years, 10 months ago (2015-02-14 01:49:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927783002/1
5 years, 10 months ago (2015-02-14 01:52:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-14 01:53:33 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 01:54:28 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8c66a5d291cc7d3c57572a8498ac5ca392563ec
Cr-Commit-Position: refs/heads/master@{#316358}

Powered by Google App Engine
This is Rietveld 408576698