net/quic/quic_sent_packet_manager.cc - Issue 927173002: deprecating FLAGS_quic_ack_notifier_informed_on_serialized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_sent_packet_manager.cc

Issue 927173002: deprecating FLAGS_quic_ack_notifier_informed_on_serialized. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Saves_a_full_packet_allocation_86104715

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_sent_packet_manager.cc

diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc

index c1811cfa576a1f1547e65f633f33ec31965832a5..7a7edffceb15e081db12ca219afb59942f39b880 100644

--- a/net/quic/quic_sent_packet_manager.cc

+++ b/net/quic/quic_sent_packet_manager.cc

@@ -561,12 +561,7 @@ bool QuicSentPacketManager::OnPacketSent(

DCHECK(!unacked_packets_.IsUnacked(sequence_number));

LOG_IF(DFATAL, bytes == 0) << "Cannot send empty packets.";

- if (original_sequence_number == 0) {

- if (!FLAGS_quic_ack_notifier_informed_on_serialized &&

- serialized_packet->retransmittable_frames) {

- ack_notifier_manager_.OnSerializedPacket(*serialized_packet);

- }

- } else {

+ if (original_sequence_number != 0) {

PendingRetransmissionMap::iterator it =

pending_retransmissions_.find(original_sequence_number);

if (it != pending_retransmissions_.end()) {

« no previous file with comments | « net/quic/quic_flags.cc ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »