net/tools/quic/end_to_end_test.cc - Issue 927173002: deprecating FLAGS_quic_ack_notifier_informed_on_serialized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 927173002: deprecating FLAGS_quic_ack_notifier_informed_on_serialized. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Saves_a_full_packet_allocation_86104715

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/quic/end_to_end_test.cc

diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc

index fa9a8e79b4a3cd59ffcf7e090440e7a3f3586095..c890f141c5752aa95b68341443e80f04fb32ef88 100644

--- a/net/tools/quic/end_to_end_test.cc

+++ b/net/tools/quic/end_to_end_test.cc

@@ -1406,8 +1406,6 @@ TEST_P(EndToEndTest, AckNotifierWithPacketLossAndBlockedSocket) {

// demonstrates that retransmissions do not break this functionality.

ValueRestore<bool> old_flag(&FLAGS_quic_attach_ack_notifiers_to_packets,

true);

- ValueRestore<bool> old_flag2(&FLAGS_quic_ack_notifier_informed_on_serialized,

- true);

SetPacketLossPercentage(5);

ASSERT_TRUE(Initialize());

« no previous file with comments | « net/quic/quic_sent_packet_manager.cc ('k') | no next file » | no next file with comments »