Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Side by Side Diff: net/quic/quic_sent_packet_manager.cc

Issue 927173002: deprecating FLAGS_quic_ack_notifier_informed_on_serialized. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Saves_a_full_packet_allocation_86104715
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_flags.cc ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_sent_packet_manager.h" 5 #include "net/quic/quic_sent_packet_manager.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
(...skipping 543 matching lines...) Expand 10 before | Expand all | Expand 10 after
554 QuicPacketSequenceNumber original_sequence_number, 554 QuicPacketSequenceNumber original_sequence_number,
555 QuicTime sent_time, 555 QuicTime sent_time,
556 QuicByteCount bytes, 556 QuicByteCount bytes,
557 TransmissionType transmission_type, 557 TransmissionType transmission_type,
558 HasRetransmittableData has_retransmittable_data) { 558 HasRetransmittableData has_retransmittable_data) {
559 QuicPacketSequenceNumber sequence_number = serialized_packet->sequence_number; 559 QuicPacketSequenceNumber sequence_number = serialized_packet->sequence_number;
560 DCHECK_LT(0u, sequence_number); 560 DCHECK_LT(0u, sequence_number);
561 DCHECK(!unacked_packets_.IsUnacked(sequence_number)); 561 DCHECK(!unacked_packets_.IsUnacked(sequence_number));
562 LOG_IF(DFATAL, bytes == 0) << "Cannot send empty packets."; 562 LOG_IF(DFATAL, bytes == 0) << "Cannot send empty packets.";
563 563
564 if (original_sequence_number == 0) { 564 if (original_sequence_number != 0) {
565 if (!FLAGS_quic_ack_notifier_informed_on_serialized &&
566 serialized_packet->retransmittable_frames) {
567 ack_notifier_manager_.OnSerializedPacket(*serialized_packet);
568 }
569 } else {
570 PendingRetransmissionMap::iterator it = 565 PendingRetransmissionMap::iterator it =
571 pending_retransmissions_.find(original_sequence_number); 566 pending_retransmissions_.find(original_sequence_number);
572 if (it != pending_retransmissions_.end()) { 567 if (it != pending_retransmissions_.end()) {
573 pending_retransmissions_.erase(it); 568 pending_retransmissions_.erase(it);
574 } else { 569 } else {
575 DLOG(DFATAL) << "Expected sequence number to be in " 570 DLOG(DFATAL) << "Expected sequence number to be in "
576 << "pending_retransmissions_. sequence_number: " 571 << "pending_retransmissions_. sequence_number: "
577 << original_sequence_number; 572 << original_sequence_number;
578 } 573 }
579 // Inform the ack notifier of retransmissions so it can calculate the 574 // Inform the ack notifier of retransmissions so it can calculate the
(...skipping 430 matching lines...) Expand 10 before | Expand all | Expand 10 after
1010 // Set up a pacing sender with a 1 millisecond alarm granularity, the same as 1005 // Set up a pacing sender with a 1 millisecond alarm granularity, the same as
1011 // the default granularity of the Linux kernel's FQ qdisc. 1006 // the default granularity of the Linux kernel's FQ qdisc.
1012 using_pacing_ = true; 1007 using_pacing_ = true;
1013 send_algorithm_.reset( 1008 send_algorithm_.reset(
1014 new PacingSender(send_algorithm_.release(), 1009 new PacingSender(send_algorithm_.release(),
1015 QuicTime::Delta::FromMilliseconds(1), 1010 QuicTime::Delta::FromMilliseconds(1),
1016 kInitialUnpacedBurst)); 1011 kInitialUnpacedBurst));
1017 } 1012 }
1018 1013
1019 } // namespace net 1014 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_flags.cc ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698