Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Issue 926823004: Increase code coverage for RenderLayer::hitTestLayer. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Increase code coverage for RenderLayer::hitTestLayer. Add tests for the NormalFlowChildren and transforms code paths. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2b68b708d343299747b18cd2b70e8f186230b8e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M sky/engine/core/rendering/RenderLayer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/tests/layout/document-elementFromPoint.sky View 2 chunks +12 lines, -0 lines 0 comments Download
M sky/tests/layout/document-elementFromPoint-expected.txt View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-19 00:06:28 UTC) #2
ojan
5 years, 10 months ago (2015-02-19 00:07:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2b68b708d343299747b18cd2b70e8f186230b8e6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698