Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: sky/engine/core/rendering/RenderLayer.cpp

Issue 926823004: Increase code coverage for RenderLayer::hitTestLayer. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | sky/tests/layout/document-elementFromPoint.sky » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 978 matching lines...) Expand 10 before | Expand all | Expand 10 after
989 // Begin by walking our list of positive layers from highest z-index down to the lowest z-index. 989 // Begin by walking our list of positive layers from highest z-index down to the lowest z-index.
990 RenderLayer* hitLayer = hitTestChildren(PositiveZOrderChildren, rootLayer, r equest, result, hitTestRect, hitTestLocation, 990 RenderLayer* hitLayer = hitTestChildren(PositiveZOrderChildren, rootLayer, r equest, result, hitTestRect, hitTestLocation,
991 localTransformState.get(), zOffsetForDes cendantsPtr, zOffset, unflattenedTransformState.get(), depthSortDescendants); 991 localTransformState.get(), zOffsetForDes cendantsPtr, zOffset, unflattenedTransformState.get(), depthSortDescendants);
992 if (hitLayer) { 992 if (hitLayer) {
993 if (!depthSortDescendants) 993 if (!depthSortDescendants)
994 return hitLayer; 994 return hitLayer;
995 candidateLayer = hitLayer; 995 candidateLayer = hitLayer;
996 } 996 }
997 997
998 // Now check our overflow objects. 998 // Now check our overflow objects.
999 // TODO(ojan): This call has no test coverage.
1000 hitLayer = hitTestChildren(NormalFlowChildren, rootLayer, request, result, h itTestRect, hitTestLocation, 999 hitLayer = hitTestChildren(NormalFlowChildren, rootLayer, request, result, h itTestRect, hitTestLocation,
1001 localTransformState.get(), zOffsetForDescendantsPtr, zOffset, unflattenedTransformState.get(), depthSortDescendants); 1000 localTransformState.get(), zOffsetForDescendantsPtr, zOffset, unflattenedTransformState.get(), depthSortDescendants);
1002 if (hitLayer) { 1001 if (hitLayer) {
1003 if (!depthSortDescendants) 1002 if (!depthSortDescendants)
1004 return hitLayer; 1003 return hitLayer;
1005 candidateLayer = hitLayer; 1004 candidateLayer = hitLayer;
1006 } 1005 }
1007 1006
1008 LayoutRect layerBounds; 1007 LayoutRect layerBounds;
1009 // FIXME(sky): Remove foregroundRect. It's unused. 1008 // FIXME(sky): Remove foregroundRect. It's unused.
(...skipping 395 matching lines...) Expand 10 before | Expand all | Expand 10 after
1405 } 1404 }
1406 } 1405 }
1407 1406
1408 void showLayerTree(const blink::RenderObject* renderer) 1407 void showLayerTree(const blink::RenderObject* renderer)
1409 { 1408 {
1410 if (!renderer) 1409 if (!renderer)
1411 return; 1410 return;
1412 showLayerTree(renderer->enclosingLayer()); 1411 showLayerTree(renderer->enclosingLayer());
1413 } 1412 }
1414 #endif 1413 #endif
OLDNEW
« no previous file with comments | « no previous file | sky/tests/layout/document-elementFromPoint.sky » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698