sky/engine/core/rendering/RenderLayer.cpp - Issue 926823004: Increase code coverage for RenderLayer::hitTestLayer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderLayer.cpp

Issue 926823004: Increase code coverage for RenderLayer::hitTestLayer. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderLayer.cpp

diff --git a/sky/engine/core/rendering/RenderLayer.cpp b/sky/engine/core/rendering/RenderLayer.cpp

index a3e8e8e4efb6e93f6dcb1b90b3a366b86ecd322f..65aea4974d692e69baf7d50716c441d0908c6bb7 100644

--- a/sky/engine/core/rendering/RenderLayer.cpp

+++ b/sky/engine/core/rendering/RenderLayer.cpp

@@ -996,7 +996,6 @@ RenderLayer* RenderLayer::hitTestLayer(RenderLayer* rootLayer, RenderLayer* cont

}

// Now check our overflow objects.

- // TODO(ojan): This call has no test coverage.

hitLayer = hitTestChildren(NormalFlowChildren, rootLayer, request, result, hitTestRect, hitTestLocation,

localTransformState.get(), zOffsetForDescendantsPtr, zOffset, unflattenedTransformState.get(), depthSortDescendants);

if (hitLayer) {

« no previous file with comments | « no previous file | sky/tests/layout/document-elementFromPoint.sky » ('j') | no next file with comments »