Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 92673003: Remove the comments settings for vim tab width and expansion variables. (Closed)

Created:
7 years ago by tfarina
Modified:
7 years ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove the comments settings for vim tab width and expansion variables. These add unnecessary bloat for everyone to carry around, so we just remove them now. The same change was made in chromium by Tony in http://codereview.chromium.org/7310019 - crrev.com/92046 BUG=None TEST=./gyp_skia R=mtklein@google.com Committed: http://code.google.com/p/skia/source/detail?r=12443

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -342 lines) Patch
M gyp/FileReaderApp.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/SampleApp.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/SimpleCocoaApp.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/SimpleiOSApp.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/angle.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/animator.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/apptype_console.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/bench.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/common.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M gyp/common_conditions.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/common_variables.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M gyp/core.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/core.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/debugger.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/edtaa.gyp View 2 chunks +0 lines, -7 lines 0 comments Download
M gyp/effects.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/effects.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/everything.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/experimental.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/flags.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/freetype.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/gm.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/gpu.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/gpu.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/gputest.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/images.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/jsoncpp.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/libjpeg.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/lua.gyp View 2 chunks +0 lines, -7 lines 0 comments Download
M gyp/most.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/opts.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/pathops_unittest.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/pdf.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/pdf.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/pdfviewer.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/pdfviewer_lib.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/pixman_test.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/ports.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/public_headers.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/sfnt.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/shapeops_demo.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/shapeops_edge.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/shapeops_tool.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/skia_lib.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/skpskgr_test.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/svg.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/tests.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/tools.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/utils.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/views.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/views_animated.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/xml.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/xps.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/zlib.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M skia.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/harfbuzz/harfbuzz.gyp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
I'm trying to upload, but git cl upload does not like me it seems. File ...
7 years ago (2013-11-27 21:12:40 UTC) #1
mtklein
lgtm
7 years ago (2013-12-02 15:08:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/92673003/40001
7 years ago (2013-12-02 15:21:03 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-02 22:23:14 UTC) #4
Message was sent while issue was closed.
Change committed as 12443

Powered by Google App Engine
This is Rietveld 408576698