Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 7310019: Remove the comments setting emands and vim tab width and expansion variables. (Closed)

Created:
9 years, 5 months ago by tony
Modified:
9 years, 5 months ago
CC:
chromium-reviews, vrk (LEFT CHROMIUM), acolwell+watch_chromium.org, amit, annacc+watch_chromium.org, ajwong+watch_chromium.org, dhollowa, ncarter (slow), idana, jam, apatrick_chromium, wez+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, tim (not reviewing), dmaclach+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Raghu Simha, cbentzel+watch_chromium.org, simonmorris+watch_chromium.org, pam+watch_chromium.org, sergeyu+watch_chromium.org, scherkus (not reviewing), jamiewalch+watch_chromium.org, hclam+watch_chromium.org, sjl, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove the comments setting emands and vim tab width and expansion variables. These were added in r28089 (http://codereview.chromium.org/256059) but are unnecessary bloat for everyone to carry around, even those that don't use emacs or vim. In an earlier change, I added editor config files in src/tools/emacs/ and src/tools/vim/ so users of the appropriate editor can source those instead. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92046

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove extra newlines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -680 lines) Patch
M app/app.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M base/allocator/allocator.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M base/base.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M breakpad/breakpad.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M build/all.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M build/common.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M build/grit_action.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M build/grit_target.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M build/linux/system.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
build/release.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/temp_gyp/googleurl.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M build/temp_gyp/pdfsqueeze.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M build/util/build_util.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M build/win/system.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/app/locales/locales.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/app/policy/cloud_policy_codegen.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/app/policy/policy_templates.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/sync/protocol/sync_proto.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/sync/tools/sync_tools.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_installer.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_installer_util.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
chrome/chrome_tests.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/default_plugin/default_plugin.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/installer/installer_tools.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/installer/mac/third_party/bsdiff/goobsdiff.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/installer/mac/third_party/xz/xz.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/installer/mini_installer.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/installer/upgrade_test.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/test/security_tests/security_tests.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome_frame/crash_reporting/crash_reporting.gyp View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome_frame/support.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M cloud_print/virtual_driver/virtual_driver.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M cloud_print/virtual_driver/win/install/virtual_driver_install.gyp View 1 1 chunk +0 lines, -7 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/virtual_driver_port_monitor.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M courgette/courgette.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M google_update/google_update.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/demos/demos.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/gles2_conform_support/gles2_conform_support.gyp View 1 1 chunk +0 lines, -7 lines 0 comments Download
M gpu/gpu.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M ipc/ipc.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M ipc/ipc.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M jingle/jingle.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M media/media.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M net/net.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M net/third_party/gssapi/gssapi.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M net/third_party/nss/ssl.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M net/tools/tld_cleanup/tld_cleanup.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M ppapi/ppapi.gypi View 1 1 chunk +0 lines, -7 lines 0 comments Download
M printing/printing.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M remoting/proto/chromotocol.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M remoting/proto/trace.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
remoting/remoting.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M sandbox/sandbox.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M sdch/sdch.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M skia/skia.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M sql/sql.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M testing/gmock.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M testing/gtest.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/adobe/flash/flash_player.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/bsdiff/bsdiff.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/bspatch/bspatch.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/bzip2/bzip2.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/cacheinvalidation/cacheinvalidation.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/cld/cld.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/codesighs/codesighs.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/expat/expat.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/gles2_book/gles2_book.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/harfbuzz-ng/harfbuzz.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/harfbuzz/harfbuzz.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/iaccessible2/iaccessible2.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/iccjpeg/iccjpeg.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/isimpledom/isimpledom.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/libevent/libevent.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/libjpeg/libjpeg.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/libpng/libpng.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/libwebp/libwebp.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/libxml/libxml.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/libxslt/libxslt.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/lzma_sdk/lzma_sdk.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/mach_override/mach_override.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/mesa/mesa.gypi View 1 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/modp_b64/modp_b64.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/npapi/npapi.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/ocmock/ocmock.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/openmax/openmax.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/protobuf/protobuf.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/qcms/qcms.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/safe_browsing/safe_browsing.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/snappy/snappy.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/yasm/yasm.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/zlib/zlib.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M tools/gtk_clipboard_dump/gtk_clipboard_dump.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M tools/imagediff/image_diff.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M tools/memory_watcher/memory_watcher.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M tools/xdisplaycheck/xdisplaycheck.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M ui/ui.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M ui/ui_base.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
ui/ui_gfx.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M ui/ui_resources.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M ui/ui_unittests.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M ui/ui_views.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M views/views.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M webkit/support/webkit_support.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M webkit/support/webkit_support.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
webkit/tools/test_shell/test_shell.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M webkit/webkit.gyp View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tony
I'm in no hurry to land this, so if you're on vacation, I can wait. ...
9 years, 5 months ago (2011-07-06 23:40:14 UTC) #1
Mark Mentovai
http://codereview.chromium.org/7310019/diff/1/base/base.gyp File base/base.gyp (right): http://codereview.chromium.org/7310019/diff/1/base/base.gyp#newcode398 base/base.gyp:398: If you’re going to get rid of the trailing ...
9 years, 5 months ago (2011-07-10 15:55:25 UTC) #2
sgk
lgtm
9 years, 5 months ago (2011-07-11 15:47:09 UTC) #3
tony
Take another look? http://codereview.chromium.org/7310019/diff/1/base/base.gyp File base/base.gyp (right): http://codereview.chromium.org/7310019/diff/1/base/base.gyp#newcode398 base/base.gyp:398: On 2011/07/10 15:55:26, Mark Mentovai wrote: ...
9 years, 5 months ago (2011-07-11 18:16:20 UTC) #4
Mark Mentovai
LGTM
9 years, 5 months ago (2011-07-11 18:17:20 UTC) #5
darin (slow to review)
> In an earlier change, I added editor config files in src/tools/emacs/ > and src/tools/vim/ ...
9 years, 5 months ago (2011-07-17 19:35:51 UTC) #6
tony
9 years, 5 months ago (2011-07-18 16:07:32 UTC) #7
On 2011/07/17 19:35:51, darin wrote:
> > In an earlier change, I added editor config files in src/tools/emacs/ 
> > and src/tools/vim/ so users of the appropriate editor can source those 
> > instead.
> 
> The old system worked without me having to do anything.  The new system
requires
> me to know about those editor files.  How would I ever discover those?

The old system had the cost of confusing people during code reviews.
https://bugs.webkit.org/show_bug.cgi?id=62399#c9
https://bugs.webkit.org/show_bug.cgi?id=62399#c15

This seems to be more like how we handle configuration for other tools (like the
http://www.chromium.org/developers/how-tos/visualstudio-tricks page or tools/gdb
or tools/git).

Powered by Google App Engine
This is Rietveld 408576698