Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 924943009: Fix template angle bracket syntax in svg (Closed)

Created:
5 years, 10 months ago by rwlbuis
Modified:
5 years, 10 months ago
Reviewers:
pdr.
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, krit, dstockwell, ed+blinkwatch_opera.com, Eric Willigers, f(malita), fs, gyuyoung.kim_webkit.org, kouhei+svg_chromium.org, Mike Lawther (Google), pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, Steve Block, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix template angle bracket syntax in svg In C++11 the parser is able to parse >> as the end of the template argument list. BUG=449681 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190593

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -72 lines) Patch
M Source/core/svg/SVGAnimateElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAnimateMotionElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedAngle.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedEnumeration.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGClipPathElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGComponentTransferFunctionElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGCursorElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGCursorElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGDocumentExtensions.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGDocumentExtensions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElement.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 7 chunks +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGElementRareData.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGEnumeration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEBlendElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEColorMatrixElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFECompositeElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEConvolveMatrixElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEDisplacementMapElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEMorphologyElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFETurbulenceElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFilterElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGGradientElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGLinearGradientElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMarkerElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMaskElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPatternElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPatternElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGRadialGradientElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextContentElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextPathElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/graphics/filters/SVGFilterBuilder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedProperty.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/properties/SVGListPropertyHelper.h View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL
5 years, 10 months ago (2015-02-20 18:14:50 UTC) #2
pdr.
lgtm
5 years, 10 months ago (2015-02-20 18:35:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924943009/1
5 years, 10 months ago (2015-02-20 18:35:33 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 22:27:15 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190593

Powered by Google App Engine
This is Rietveld 408576698