Disallow constructing the Notification object in a Service Worker.

Disallow constructing the Notification object in a Service Worker.

Following the steps for the Notification constructor, we should throw
a TypeError when its called on the ServiceWorkerGlobalScope.

https://notifications.spec.whatwg.org/#constructors

This is part of a two-sided patch:
  [1] https://codereview.chromium.org/930963002
  [2] This patch.

BUG=459038
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190271

[Peter Beverloo, 2015-02-16 17:37:04]

peter@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[Peter Beverloo, 2015-02-16 17:37:05]

PTAL

[Michael van Ouwerkerk, 2015-02-16 18:16:09]

lgtm with nits

https://codereview.chromium.org/923443005/diff/1/LayoutTests/http/tests/notif...
File
LayoutTests/http/tests/notifications/resources/serviceworker-notification-constructor.js
(right):

https://codereview.chromium.org/923443005/diff/1/LayoutTests/http/tests/notif...
LayoutTests/http/tests/notifications/resources/serviceworker-notification-constructor.js:2:
importScripts('/resources/testharness-helpers.js');
nit: can we use a relative url here?

https://codereview.chromium.org/923443005/diff/1/LayoutTests/http/tests/notif...
File LayoutTests/http/tests/notifications/serviceworker-throw-constructor.html
(right):

https://codereview.chromium.org/923443005/diff/1/LayoutTests/http/tests/notif...
LayoutTests/http/tests/notifications/serviceworker-throw-constructor.html:11: //
Tests that the constructing a Notification object in a Service Worker
s/that the/that/

[Peter Beverloo, 2015-02-16 18:23:53]

New patchsets have been uploaded after l-g-t-m from mvanouwerkerk@chromium.org

[Peter Beverloo, 2015-02-16 18:23:57]

https://codereview.chromium.org/923443005/diff/1/LayoutTests/http/tests/notif...
File
LayoutTests/http/tests/notifications/resources/serviceworker-notification-constructor.js
(right):

https://codereview.chromium.org/923443005/diff/1/LayoutTests/http/tests/notif...
LayoutTests/http/tests/notifications/resources/serviceworker-notification-constructor.js:2:
importScripts('/resources/testharness-helpers.js');
On 2015/02/16 18:16:09, Michael van Ouwerkerk wrote:
> nit: can we use a relative url here?

Done.

https://codereview.chromium.org/923443005/diff/1/LayoutTests/http/tests/notif...
File LayoutTests/http/tests/notifications/serviceworker-throw-constructor.html
(right):

https://codereview.chromium.org/923443005/diff/1/LayoutTests/http/tests/notif...
LayoutTests/http/tests/notifications/serviceworker-throw-constructor.html:11: //
Tests that the constructing a Notification object in a Service Worker
On 2015/02/16 18:16:09, Michael van Ouwerkerk wrote:
> s/that the/that/

Done.

[Peter Beverloo, 2015-02-16 19:43:11]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2015-02-16 19:43:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/923443005/20001

[commit-bot: I haz the power, 2015-02-16 19:46:46]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190271