Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 930963002: Move the PushMessagingBrowserTest to use SWR.showNotification(). (Closed)

Created:
5 years, 10 months ago by Peter Beverloo
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the PushMessagingBrowserTest to use SWR.showNotification(). This will allow us to start throwing a TypeError per the specification when constructing a new Notification object in a Service Worker. This is part of a two-sided patch: [1] This patch. [2] https://codereview.chromium.org/923443005 BUG=459038 Committed: https://crrev.com/a4b68d8fa83978cf78c84398e852366188665c55 Cr-Commit-Position: refs/heads/master@{#316496}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M chrome/test/data/push_messaging/service_worker.js View 2 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Peter Beverloo
PTAL
5 years, 10 months ago (2015-02-16 17:36:46 UTC) #2
Michael van Ouwerkerk
lgtm - please add a bug number
5 years, 10 months ago (2015-02-16 18:15:06 UTC) #3
Peter Beverloo
On 2015/02/16 18:15:06, Michael van Ouwerkerk wrote: > lgtm - please add a bug number ...
5 years, 10 months ago (2015-02-16 18:21:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930963002/1
5 years, 10 months ago (2015-02-16 18:22:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-16 18:32:56 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 18:33:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4b68d8fa83978cf78c84398e852366188665c55
Cr-Commit-Position: refs/heads/master@{#316496}

Powered by Google App Engine
This is Rietveld 408576698