LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js - Issue 923443005: Disallow constructing the Notification object in a Service Worker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

Issue 923443005: Disallow constructing the Notification object in a Service Worker. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/notifications/resources/serviceworker-notification-constructor.js ('k') | LayoutTests/http/tests/notifications/serviceworker-throw-constructor.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

diff --git a/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js b/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

index 94ffdf36c06017e7653560149d9fc9a32b338d3b..148df6e2898e466470d8ca4772827945bf2204e8 100644

--- a/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

+++ b/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

@@ -12,15 +12,12 @@ test(function() {

assert_equals(event.notification, null);

assert_inherits(event, 'waitUntil');

- var notification = new Notification('foo');

var eventWithInit = new NotificationEvent('NotificationEvent',

{ cancelable: true,

- bubbles: true,

- notification: notification,

+ bubbles: true

});

assert_equals(eventWithInit.cancelable, true);

assert_equals(eventWithInit.bubbles, true);

- assert_equals(eventWithInit.notification, notification);

}, 'NotificationEvent is exposed, and has the expected interface.');