Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 923363002: Gracefully handle nested frame detaches. (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
Reviewers:
haraken, Nate Chapin, dcheng
CC:
blink-reviews, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Gracefully handle nested frame detaches. If a frame detach triggered a load cancellation that resulted in another detach, the initiating detach operation wasn't quite prepared. Address by checking for the completion of a frame detach after detachment of the loader-specific operations (FrameLoader.) R=haraken BUG=452253 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190184

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -4 lines) Patch
A LayoutTests/fast/frames/detach-frame-nested-no-crash.html View 1 chunk +18 lines, -0 lines 0 comments Download
A + LayoutTests/fast/frames/detach-frame-nested-no-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/frames/resources/detach-frame-nested-subframe.html View 1 chunk +19 lines, -0 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look.
5 years, 10 months ago (2015-02-14 13:23:14 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-14 17:11:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923363002/1
5 years, 10 months ago (2015-02-14 18:27:32 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 18:30:55 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190184

Powered by Google App Engine
This is Rietveld 408576698