Source/core/frame/LocalFrame.cpp - Issue 923363002: Gracefully handle nested frame detaches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/LocalFrame.cpp

Issue 923363002: Gracefully handle nested frame detaches. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/LocalFrame.cpp

diff --git a/Source/core/frame/LocalFrame.cpp b/Source/core/frame/LocalFrame.cpp

index df30e7ce232b3722c107339e01bb6b01a59e377c..efa8c40b47e6976d713c068dc4dd96e86d694749 100644

--- a/Source/core/frame/LocalFrame.cpp

+++ b/Source/core/frame/LocalFrame.cpp

@@ -270,10 +270,10 @@ void LocalFrame::detach()

// will trigger the unload event handlers of any child frames, and those event

// handlers might start a new subresource load in this frame.

m_loader.stopAllLoaders();

+ m_loader.detach();

if (!client())

return;

- m_loader.detach();

// Notify ScriptController that the frame is closing, since its cleanup ends up calling

// back to FrameLoaderClient via WindowProxy.

script().clearForClose();