Source/core/loader/FrameLoader.cpp - Issue 923363002: Gracefully handle nested frame detaches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FrameLoader.cpp

Issue 923363002: Gracefully handle nested frame detaches. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/loader/FrameLoader.cpp

diff --git a/Source/core/loader/FrameLoader.cpp b/Source/core/loader/FrameLoader.cpp

index 2afd8c0b820d3e7c27888030f700c357e30858f4..21a778bf884217b642a37425dd44d803b922c422 100644

--- a/Source/core/loader/FrameLoader.cpp

+++ b/Source/core/loader/FrameLoader.cpp

@@ -1065,8 +1065,10 @@ void FrameLoader::detach()

Frame* parent = m_frame->tree().parent();

if (parent && parent->isLocalFrame())

toLocalFrame(parent)->loader().scheduleCheckCompleted();

- m_progressTracker->dispose();

- m_progressTracker.clear();

+ if (m_progressTracker) {

+ m_progressTracker->dispose();

+ m_progressTracker.clear();

+ }

setOpener(0);

}

« no previous file with comments | « Source/core/frame/LocalFrame.cpp ('k') | no next file » | no next file with comments »