Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 923143002: Split out methods in GrGpuResource::CacheAccess that can be called outside of the cache. (Closed)

Created:
5 years, 10 months ago by bsalomon
Modified:
5 years, 10 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Split out methods in GrGpuResource::CacheAccess that can be called outside of the cache. Committed: https://skia.googlesource.com/skia/+/3582d3ee9fffdec715f5e4949a241ab08e6271ec

Patch Set 1 #

Patch Set 2 : minor #

Patch Set 3 : fix warning? #

Patch Set 4 : do warning workaround in the right place #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -199 lines) Patch
M bench/GrResourceCacheBench.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M gyp/gpu.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrGpuResource.h View 1 1 chunk +8 lines, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 4 chunks +4 lines, -12 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrGpuResource.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrGpuResourceCacheAccess.h View 3 chunks +13 lines, -55 lines 0 comments Download
A + src/gpu/GrGpuResourcePriv.h View 1 3 chunks +30 lines, -63 lines 0 comments Download
M src/gpu/GrResourceCache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrResourceCache.cpp View 12 chunks +22 lines, -23 lines 0 comments Download
M src/gpu/GrTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/image/SkImage_Gpu.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/image/SkSurface_Gpu.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 2 3 15 chunks +32 lines, -28 lines 0 comments Download
M tests/SurfaceTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
bsalomon
I'm going to add some members to GrGpuResource that should only ever be manipulated by ...
5 years, 10 months ago (2015-02-13 18:17:50 UTC) #2
robertphillips
lgtm
5 years, 10 months ago (2015-02-13 19:17:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923143002/20001
5 years, 10 months ago (2015-02-13 19:32:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/2056) Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 10 months ago (2015-02-13 19:35:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923143002/40001
5 years, 10 months ago (2015-02-13 21:03:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/2065)
5 years, 10 months ago (2015-02-13 21:06:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923143002/60001
5 years, 10 months ago (2015-02-13 22:08:27 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 22:20:09 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/3582d3ee9fffdec715f5e4949a241ab08e6271ec

Powered by Google App Engine
This is Rietveld 408576698