Issue 923093003: Add support for named arguments to our bindings generation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 923093003: Add support for named arguments to our bindings generation. (Closed)

Created:
5 years, 10 months ago by eseidel

Modified:
5 years, 10 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add support for named arguments to our bindings generation. This doesn't yet support having both named and optional arguments, but once I have an example of that it should be trivial to add. I also cleaned up the generation a little so the generated dart file looks nicer. :) R=abarth@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/6f31ce67daa8aa120c3b49df0aa9dcf8512e4324

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -9 lines)			Patch
M	sky/engine/bindings/IDLExtendedAttributes.txt	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	sky/engine/bindings/scripts/dart_methods.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/engine/bindings/scripts/templates/interface_dart.template	View	3 chunks	+10 lines, -7 lines	0 comments	Download
M	sky/engine/core/dom/Node.idl	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

eseidel

5 years, 10 months ago (2015-02-17 19:00:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6f31ce67daa8aa120c3b49df0aa9dcf8512e4324 (presubmit successful).