sky/engine/bindings/scripts/dart_methods.py - Issue 923093003: Add support for named arguments to our bindings generation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/scripts/dart_methods.py

Issue 923093003: Add support for named arguments to our bindings generation. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/scripts/dart_methods.py

diff --git a/sky/engine/bindings/scripts/dart_methods.py b/sky/engine/bindings/scripts/dart_methods.py

index 25b3d88bd9d6fafa3ea8f076e91bb60e38146c94..014f28b7b49e7f29495ee11812e2ec08e6b36bd3 100644

--- a/sky/engine/bindings/scripts/dart_methods.py

+++ b/sky/engine/bindings/scripts/dart_methods.py

@@ -125,6 +125,7 @@ def argument_context(interface, method, argument, index):

'local_cpp_type': local_cpp_type,

# FIXME: check that the default value's type is compatible with the argument's

'default_value': default_value,

+ 'is_named': 'Named' in extended_attributes,

'dart_default_value': dart_default_value,

'enum_validation_expression': idl_type.enum_validation_expression,

'preprocessed_type': preprocessed_type,