Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: sky/engine/bindings/scripts/dart_methods.py

Issue 923093003: Add support for named arguments to our bindings generation. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2013 Google Inc. All rights reserved. 1 # Copyright (C) 2013 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 context.update({ 118 context.update({
119 'cpp_type': idl_type.cpp_type_args(extended_attributes=extended_attribut es, 119 'cpp_type': idl_type.cpp_type_args(extended_attributes=extended_attribut es,
120 raw_type=True, 120 raw_type=True,
121 used_in_cpp_sequence=False), 121 used_in_cpp_sequence=False),
122 'dart_type': dart_type, 122 'dart_type': dart_type,
123 'implemented_as': idl_type.implemented_as, 123 'implemented_as': idl_type.implemented_as,
124 'cpp_value': this_cpp_value, 124 'cpp_value': this_cpp_value,
125 'local_cpp_type': local_cpp_type, 125 'local_cpp_type': local_cpp_type,
126 # FIXME: check that the default value's type is compatible with the argu ment's 126 # FIXME: check that the default value's type is compatible with the argu ment's
127 'default_value': default_value, 127 'default_value': default_value,
128 'is_named': 'Named' in extended_attributes,
128 'dart_default_value': dart_default_value, 129 'dart_default_value': dart_default_value,
129 'enum_validation_expression': idl_type.enum_validation_expression, 130 'enum_validation_expression': idl_type.enum_validation_expression,
130 'preprocessed_type': preprocessed_type, 131 'preprocessed_type': preprocessed_type,
131 'is_array_or_sequence_type': not not idl_type.native_array_element_type, 132 'is_array_or_sequence_type': not not idl_type.native_array_element_type,
132 'is_strict_type_checking': 'DartStrictTypeChecking' in extended_attribut es, 133 'is_strict_type_checking': 'DartStrictTypeChecking' in extended_attribut es,
133 'dart_set_return_value_for_main_world': dart_set_return_value(interface. name, method, 134 'dart_set_return_value_for_main_world': dart_set_return_value(interface. name, method,
134 this_cpp_v alue, for_main_world=True), 135 this_cpp_v alue, for_main_world=True),
135 'dart_set_return_value': dart_set_return_value(interface.name, method, t his_cpp_value), 136 'dart_set_return_value': dart_set_return_value(interface.name, method, t his_cpp_value),
136 'arg_index': arg_index, 137 'arg_index': arg_index,
137 'dart_value_to_local_cpp_value': dart_value_to_local_cpp_value(interface , 138 'dart_value_to_local_cpp_value': dart_value_to_local_cpp_value(interface ,
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 # removeEventListener methods that should be added in somewhere. 237 # removeEventListener methods that should be added in somewhere.
237 # There is also some logic in systemnative.py to force a null check 238 # There is also some logic in systemnative.py to force a null check
238 # for the useCapture argument of those same methods that we may need to 239 # for the useCapture argument of those same methods that we may need to
239 # pull over. 240 # pull over.
240 null_check = ((argument.is_optional and idl_type.is_callback_interface) or 241 null_check = ((argument.is_optional and idl_type.is_callback_interface) or
241 (argument.default_value and argument.default_value.is_null)) 242 (argument.default_value and argument.default_value.is_null))
242 243
243 return idl_type.dart_value_to_local_cpp_value( 244 return idl_type.dart_value_to_local_cpp_value(
244 extended_attributes, name, null_check, has_type_checking_interface, 245 extended_attributes, name, null_check, has_type_checking_interface,
245 index=index, auto_scope=auto_scope) 246 index=index, auto_scope=auto_scope)
OLDNEW
« no previous file with comments | « sky/engine/bindings/IDLExtendedAttributes.txt ('k') | sky/engine/bindings/scripts/templates/interface_dart.template » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698