Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Unified Diff: content/public/browser/web_contents.h

Issue 921443003: Fix RenderFrameCreated and RenderFrameDeleted WebContentsObserver methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents.h
diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h
index 879e8d8513c03fa6ccb621249098bb66873a0fab..bf55cac55075ecf8c85c8786f6567bc388655e5f 100644
--- a/content/public/browser/web_contents.h
+++ b/content/public/browser/web_contents.h
@@ -122,6 +122,12 @@ class WebContents : public PageNavigator,
// Used to specify the location context which display the new view should
// belong. This can be nullptr if not needed.
gfx::NativeView context;
+
+ // Used to specify that the new WebContents creation is driven by the
+ // renderer. In this case, the renderer-side objects, such as
Charlie Reis 2015/02/12 23:51:26 nit: Let's try to say "renderer process" when we c
nasko 2015/02/13 00:18:52 Good catch! I've been trying to avoid using just r
+ // RenderFrameHost, have already been created on the renderer side, and
Charlie Reis 2015/02/12 23:51:26 RenderFrame :)
nasko 2015/02/13 00:18:51 Done.
+ // WebContents construction should take this into account.
+ bool renderer_initiated_creation;
};
// Creates a new WebContents.

Powered by Google App Engine
This is Rietveld 408576698