Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Side by Side Diff: content/public/browser/web_contents.h

Issue 921443003: Fix RenderFrameCreated and RenderFrameDeleted WebContentsObserver methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
7 7
8 #include <set> 8 #include <set>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 115
116 // True if the contents should be initially hidden. 116 // True if the contents should be initially hidden.
117 bool initially_hidden; 117 bool initially_hidden;
118 118
119 // If non-null then this WebContents will be hosted by a BrowserPlugin. 119 // If non-null then this WebContents will be hosted by a BrowserPlugin.
120 BrowserPluginGuestDelegate* guest_delegate; 120 BrowserPluginGuestDelegate* guest_delegate;
121 121
122 // Used to specify the location context which display the new view should 122 // Used to specify the location context which display the new view should
123 // belong. This can be nullptr if not needed. 123 // belong. This can be nullptr if not needed.
124 gfx::NativeView context; 124 gfx::NativeView context;
125
126 // Used to specify that the new WebContents creation is driven by the
127 // renderer. In this case, the renderer-side objects, such as
Charlie Reis 2015/02/12 23:51:26 nit: Let's try to say "renderer process" when we c
nasko 2015/02/13 00:18:52 Good catch! I've been trying to avoid using just r
128 // RenderFrameHost, have already been created on the renderer side, and
Charlie Reis 2015/02/12 23:51:26 RenderFrame :)
nasko 2015/02/13 00:18:51 Done.
129 // WebContents construction should take this into account.
130 bool renderer_initiated_creation;
125 }; 131 };
126 132
127 // Creates a new WebContents. 133 // Creates a new WebContents.
128 CONTENT_EXPORT static WebContents* Create(const CreateParams& params); 134 CONTENT_EXPORT static WebContents* Create(const CreateParams& params);
129 135
130 // Similar to Create() above but should be used when you need to prepopulate 136 // Similar to Create() above but should be used when you need to prepopulate
131 // the SessionStorageNamespaceMap of the WebContents. This can happen if 137 // the SessionStorageNamespaceMap of the WebContents. This can happen if
132 // you duplicate a WebContents, try to reconstitute it from a saved state, 138 // you duplicate a WebContents, try to reconstitute it from a saved state,
133 // or when you create a new WebContents based on another one (eg., when 139 // or when you create a new WebContents based on another one (eg., when
134 // servicing a window.open() call). 140 // servicing a window.open() call).
(...skipping 483 matching lines...) Expand 10 before | Expand all | Expand 10 after
618 624
619 private: 625 private:
620 // This interface should only be implemented inside content. 626 // This interface should only be implemented inside content.
621 friend class WebContentsImpl; 627 friend class WebContentsImpl;
622 WebContents() {} 628 WebContents() {}
623 }; 629 };
624 630
625 } // namespace content 631 } // namespace content
626 632
627 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 633 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698