content/browser/web_contents/web_contents_impl_unittest.cc - Issue 921443003: Fix RenderFrameCreated and RenderFrameDeleted WebContentsObserver methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 921443003: Fix RenderFrameCreated and RenderFrameDeleted WebContentsObserver methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/frame_tree_unittest.cc ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/browser/web_contents.h » ('j') | content/public/browser/web_contents.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl_unittest.cc

diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc

index ab40bcd466f7431fb7b60094387f79825a8ff74e..5f25a5368e7ec271f982b3467c78157f6fcc2f52 100644

--- a/content/browser/web_contents/web_contents_impl_unittest.cc

+++ b/content/browser/web_contents/web_contents_impl_unittest.cc

@@ -520,6 +520,7 @@ TEST_F(WebContentsImplTest, CrossSiteBoundaries) {

}

// DidNavigate from the pending page

+ pending_rfh->PrepareForCommit(url2);

contents()->TestDidNavigate(

pending_rfh, 1, url2, ui::PAGE_TRANSITION_TYPED);

SiteInstance* instance2 = contents()->GetSiteInstance();