Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 921323003: Make `git cl try` to the same as hitting cq (except for presubmit). (Closed)

Created:
5 years, 10 months ago by Nico
Modified:
5 years, 10 months ago
CC:
chromium-reviews, Dan Beam, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make `git cl try` to the same as hitting cq (except for presubmit). PRESUBMIT.py used to contain a handwritten list of bots to trigger on `git cl try`. It was always out of sync with what the cq did. https://codereview.chromium.org/823823002 awesomely made `git cl try` do the same thing as the commit queue, but it kept a few special-case rules around. It's better to not have these special cases: Once the developer hits cq, all the "intelligently" skipped bots need to be run anyways. More importantly, there should be only one system to decide what to run and it should be identical for cq and `git cl try`. Currently, we think this system is the `analyze` step, and it does a decent job of that already. BUG=none (but made possible by 443613) Committed: https://crrev.com/4f02f4cd6c8b9087ecd286c905b15e253d88d82f Cr-Commit-Position: refs/heads/master@{#317597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
M PRESUBMIT.py View 2 chunks +0 lines, -29 lines 0 comments Download
M PRESUBMIT_test.py View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Nico
5 years, 10 months ago (2015-02-13 23:10:39 UTC) #2
Sergiy Byelozyorov
l-g-t-m, but I'll let Jochen do the review
5 years, 10 months ago (2015-02-14 04:11:02 UTC) #4
Nico
jochen: ping
5 years, 10 months ago (2015-02-17 15:34:46 UTC) #5
Sergiy Byelozyorov
On 2015/02/17 15:34:46, Nico wrote: > jochen: ping fyi, jochen is OOO until the end ...
5 years, 10 months ago (2015-02-18 20:18:10 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-23 09:58:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921323003/1
5 years, 10 months ago (2015-02-23 16:56:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 17:00:43 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 17:01:35 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f02f4cd6c8b9087ecd286c905b15e253d88d82f
Cr-Commit-Position: refs/heads/master@{#317597}

Powered by Google App Engine
This is Rietveld 408576698