Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: PRESUBMIT.py

Issue 921323003: Make `git cl try` to the same as hitting cq (except for presubmit). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | PRESUBMIT_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 18fe621e4f5524f6156c5e93f5982f4d227d9e7b..01e09248c6cf7d850a0a2f8df897cf1e2eb47ee8 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -1714,29 +1714,6 @@ def GetPreferredTryMasters(project, change):
import re
files = change.LocalPaths()
- if not files or all(re.search(r'[\\\/]OWNERS$', f) for f in files):
- return {}
-
- if all(re.search(r'\.(m|mm)$|(^|[\\\/_])mac[\\\/_.]', f) for f in files):
- return GetDefaultTryConfigs([
- 'mac_chromium_compile_dbg_ng',
- 'mac_chromium_rel_ng',
- ])
- if all(re.search('(^|[/_])win[/_.]', f) for f in files):
- return GetDefaultTryConfigs([
- 'win8_chromium_rel',
- 'win_chromium_rel_ng',
- 'win_chromium_x64_rel_ng',
- ])
- if all(re.search(r'(^|[\\\/_])android[\\\/_.]', f) and
- not re.search(r'(^|[\\\/_])devtools[\\\/_.]', f) for f in files):
- return GetDefaultTryConfigs([
- 'android_aosp',
- 'android_rel_tests_recipe',
- ])
- if all(re.search(r'[\\\/_]ios[\\\/_.]', f) for f in files):
- return GetDefaultTryConfigs(['ios_rel_device', 'ios_dbg_simulator'])
-
import os
import json
with open(os.path.join(
@@ -1757,10 +1734,4 @@ def GetPreferredTryMasters(project, change):
if 'presubmit' in builder:
builders[master].pop(builder)
- # Match things like path/aura/file.cc and path/file_aura.cc.
- # Same for chromeos.
- if any(re.search(r'[\\\/_](aura|chromeos)', f) for f in files):
- tryserver_linux = builders.setdefault('tryserver.chromium.linux', {})
- tryserver_linux['linux_chromium_chromeos_asan_rel_ng'] = ['defaulttests']
-
return builders
« no previous file with comments | « no previous file | PRESUBMIT_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698