Use checked-in CQ config to get trybots to launch from PRESUBMIT.py

Use checked-in CQ config to get trybots to launch from PRESUBMIT.py

BUG=443613
R=sergiyb@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/ef2afd4850fdac16dcbfedcbd6a2119ea07aeebd

[Paweł Hajdan Jr., 2014-12-23 13:52:17]

phajdan.jr@chromium.org changed reviewers:
+ sergiyb@chromium.org

[Sergiy Byelozyorov, 2014-12-24 16:12:34]

lgtm w/ comments

https://codereview.chromium.org/823823002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/823823002/diff/20001/PRESUBMIT.py#newcode1688
PRESUBMIT.py:1688: import os
Why import here and not on top of the file? Also shouldn't PRESUBMIT.py scripts
use input_api? Or is only in infra?

https://codereview.chromium.org/823823002/diff/20001/PRESUBMIT.py#newcode1703
PRESUBMIT.py:1703: 'linux_chromium_chromeos_asan_rel_ng'] = ['defaulttests']
This is a bit hard to read. Can you please split it into two lines?

tryserver_linux = builders.setdefault('tryserver.chromium.linux', {})
tryserver_linux['linux_chromium_chromeos_asan_rel_ng'] = ['defaulttests']

[commit-bot: I haz the power, 2015-01-07 16:02:03]

Patchset 3 (id:??) landed as
https://crrev.com/ef2afd4850fdac16dcbfedcbd6a2119ea07aeebd
Cr-Commit-Position: refs/heads/master@{#310290}

[Paweł Hajdan Jr., 2015-01-07 16:02:09]

Committed patchset #3 (id:40001) manually as
ef2afd4850fdac16dcbfedcbd6a2119ea07aeebd (presubmit successful).

[Paweł Hajdan Jr., 2015-01-07 16:04:27]

https://codereview.chromium.org/823823002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/823823002/diff/20001/PRESUBMIT.py#newcode1688
PRESUBMIT.py:1688: import os
On 2014/12/24 16:12:34, Sergiy Byelozyorov wrote:
> Why import here and not on top of the file? Also shouldn't PRESUBMIT.py
scripts
> use input_api? Or is only in infra?

GetPreferredTryMasters unfortunately doesn't get input_api (CheckChangeOnCommit
does).

Also see pre-existing "import re" above on line 1662.

I agree it's ugly and could be improved.

https://codereview.chromium.org/823823002/diff/20001/PRESUBMIT.py#newcode1703
PRESUBMIT.py:1703: 'linux_chromium_chromeos_asan_rel_ng'] = ['defaulttests']
On 2014/12/24 16:12:34, Sergiy Byelozyorov wrote:
> This is a bit hard to read. Can you please split it into two lines?
> 
> tryserver_linux = builders.setdefault('tryserver.chromium.linux', {})
> tryserver_linux['linux_chromium_chromeos_asan_rel_ng'] = ['defaulttests']

Done.