Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 921283002: [Telemetry] Add comment to page_set_smoke_test. Noop change (Closed)

Created:
5 years, 10 months ago by nednguyen
Modified:
5 years, 10 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Add comment to page_set_smoke_test. Noop change Committed: https://crrev.com/82bfff9ffd4cc01ecd3f5d03afe20c13fbb72dea Cr-Commit-Position: refs/heads/master@{#316311}

Patch Set 1 #

Patch Set 2 : Make the comment a little bit clearer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
nednguyen
5 years, 10 months ago (2015-02-13 20:30:41 UTC) #2
sullivan
lgtm
5 years, 10 months ago (2015-02-13 20:31:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921283002/20001
5 years, 10 months ago (2015-02-13 20:34:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/25034)
5 years, 10 months ago (2015-02-13 22:08:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921283002/20001
5 years, 10 months ago (2015-02-13 22:18:08 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-13 22:50:48 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 22:52:06 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/82bfff9ffd4cc01ecd3f5d03afe20c13fbb72dea
Cr-Commit-Position: refs/heads/master@{#316311}

Powered by Google App Engine
This is Rietveld 408576698