OLD | NEW |
1 # Copyright 2014 The Chromium Authors. All rights reserved. | 1 # Copyright 2014 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 import logging | 5 import logging |
6 import os | 6 import os |
7 import unittest | 7 import unittest |
8 | 8 |
9 from telemetry.core import browser_credentials | 9 from telemetry.core import browser_credentials |
10 from telemetry.core import discover | 10 from telemetry.core import discover |
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
96 msg='page_set\'s archive_data_file path must have type string') | 96 msg='page_set\'s archive_data_file path must have type string') |
97 | 97 |
98 if page_set.user_agent_type is not None: | 98 if page_set.user_agent_type is not None: |
99 self.assertTrue( | 99 self.assertTrue( |
100 isinstance(page_set.user_agent_type, str), | 100 isinstance(page_set.user_agent_type, str), |
101 msg='page_set\'s user_agent_type must have type string') | 101 msg='page_set\'s user_agent_type must have type string') |
102 | 102 |
103 def CheckAttributesOfPageBasicAttributes(self, page): | 103 def CheckAttributesOfPageBasicAttributes(self, page): |
104 self.assertTrue(not hasattr(page, 'disabled')) | 104 self.assertTrue(not hasattr(page, 'disabled')) |
105 self.assertTrue( | 105 self.assertTrue( |
| 106 # We use basestring instead of str because page's url can be string of |
| 107 # unicode. |
106 isinstance(page.url, basestring), | 108 isinstance(page.url, basestring), |
107 msg='page %s \'s url must have type string' % page.display_name) | 109 msg='page %s \'s url must have type string' % page.display_name) |
108 self.assertTrue( | 110 self.assertTrue( |
109 isinstance(page.page_set, page_set_module.PageSet), | 111 isinstance(page.page_set, page_set_module.PageSet), |
110 msg='page %s \'s page_set must be an instance of ' | 112 msg='page %s \'s page_set must be an instance of ' |
111 'telemetry.page.page_set.PageSet' % page.display_name) | 113 'telemetry.page.page_set.PageSet' % page.display_name) |
112 self.assertTrue( | 114 self.assertTrue( |
113 isinstance(page.name, str), | 115 isinstance(page.name, str), |
114 msg='page %s \'s name field must have type string' % page.display_name) | 116 msg='page %s \'s name field must have type string' % page.display_name) |
115 self.assertTrue( | 117 self.assertTrue( |
(...skipping 25 matching lines...) Expand all Loading... |
141 if not classes.IsDirectlyConstructable(page_set_class): | 143 if not classes.IsDirectlyConstructable(page_set_class): |
142 # We can't test page sets that aren't directly constructable since we | 144 # We can't test page sets that aren't directly constructable since we |
143 # don't know what arguments to put for the constructor. | 145 # don't know what arguments to put for the constructor. |
144 continue | 146 continue |
145 page_set = page_set_class() | 147 page_set = page_set_class() |
146 logging.info('Testing %s', page_set.file_path) | 148 logging.info('Testing %s', page_set.file_path) |
147 self.CheckArchive(page_set) | 149 self.CheckArchive(page_set) |
148 self.CheckCredentials(page_set) | 150 self.CheckCredentials(page_set) |
149 self.CheckAttributes(page_set) | 151 self.CheckAttributes(page_set) |
150 self.CheckNoMixedInBetweenLegacyRunMethodsAndRunPageInteractions(page_set) | 152 self.CheckNoMixedInBetweenLegacyRunMethodsAndRunPageInteractions(page_set) |
OLD | NEW |